Date: Thu, 6 Nov 2003 13:43:47 +0100 From: Simon 'corecode' Schubert <corecode@fs.ei.tum.de> To: Simon Barner <barner@in.tum.de> Cc: fjoe@iclub.nsu.ru Subject: Re: ports/57226: audio/cdparanoia fix to work with cooked_ioctl under -CURRENT Message-ID: <20031106134347.0e2989bf.corecode@fs.ei.tum.de> In-Reply-To: <20031106013446.GA25025@zi025.glhnet.mhn.de> References: <200311050450.hA54oLUA027741@freefall.freebsd.org> <20031105130540.GB411@zi025.glhnet.mhn.de> <86llqupkad.wl@gray.plala.or.jp> <20031106013446.GA25025@zi025.glhnet.mhn.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Thu__6_Nov_2003_13_43_47_+0100_kBtuBtrY2yfhYSpy
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Lately Simon Barner told:
> + for (;;) {
> -+ arg.nframes = sectors;
> -+ if (ioctl(d->ioctl_fd, CDIOCREADAUDIO, &arg) == -1) {
> ++ if (ioctl(d->ioctl_fd, CDRIOCSETBLOCKSIZE, &bsize) == -1)
> ++ return -7;
> ++ if (pread(d->ioctl_fd, p, sectors*bsize, begin*bsize) != sectors*bsize) {
> + if (!d->error_retry)
> + return -7;
> +
looks good, but you might want to do the ioctl before the loop.
Also, I'd like to drop my maintainership. If you are interested, take it
cheers
simon
--
/"\ http://corecode.ath.cx/#donate
\ /
\ ASCII Ribbon Campaign
/ \ Against HTML Mail and News
--Signature=_Thu__6_Nov_2003_13_43_47_+0100_kBtuBtrY2yfhYSpy
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
iD8DBQE/qkIHr5S+dk6z85oRAlY5AKCruei83QT6+bYn83HjHHSOEgzyvwCfeTsA
GLZd4S+335D7j0+l982WK0A=
=JY9w
-----END PGP SIGNATURE-----
--Signature=_Thu__6_Nov_2003_13_43_47_+0100_kBtuBtrY2yfhYSpy--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031106134347.0e2989bf.corecode>