Date: Mon, 20 Aug 2001 19:19:38 +0300 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Akinori MUSHA <knu@iDaemons.org> Cc: portmgr@FreeBSD.org, ports@FreeBSD.org Subject: Re: bsd.port.mk: renaming cookie files Message-ID: <3B81389A.167A5788@FreeBSD.org> References: <86snernc9l.wl@archon.local.idaemons.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Akinori MUSHA wrote:
> Hi,
>
> I'd suggest including ${PKGNAME} in the name of each cookie file, so
> that a port would never install the stuff built in the outdated
> working directory.
>
> With the following patch, bsd.port.mk will not think a port is already
> built when the PKGNAME doesn't match that of what is built in the
> WRKDIR.
>
> Any comments?
Nice idea, but I think that we can go further down the road and change WRKDIR to be
${WRKDIRPREFIX}${.CURDIR}/work-${PKGNAME}. This way we will also protect packages
whose distfiles were updated without version bump (hence WRKSRC remains the same) and
those that doesn't have version number in their WRKSRC at all (e.g. XFree86) - you
know unpacking new version on top of older one can give number of weird problems
raging from make (1) not rebuiling all targets to configure script picking pieces of
all setup via config.cache file. For compatibility purposed bsd.ports.mk could be
tweaked to create work --> work-${PKGNAME}symlink in the ports's top directory.
What do you think?
-Maxim
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3B81389A.167A5788>