Date: Sat, 4 Feb 2012 10:32:56 -0600 From: Guy Helmer <ghelmer@palisadesystems.com> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r230869 - head/usr.sbin/daemon Message-ID: <74AF334B-CD90-4A43-96C4-1CF69C8EA42B@palisadesystems.com> In-Reply-To: <20120204074201.GA1694@garage.freebsd.pl> References: <201202011641.q11Gf0j6095461@svn.freebsd.org> <20120204074201.GA1694@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Feb 4, 2012, at 1:42 AM, Pawel Jakub Dawidek wrote: > On Wed, Feb 01, 2012 at 04:41:00PM +0000, Guy Helmer wrote: >> Author: ghelmer >> Date: Wed Feb 1 16:40:59 2012 >> New Revision: 230869 >> URL: http://svn.freebsd.org/changeset/base/230869 >>=20 >> Log: >> Change the notes about the pidfile to include Doug's preference >> for pre-creating the pidfile with appropriate owner and permissions. >>=20 >> Requested by dougb >=20 > Pre-creating pidfiles? That sounds weird. The common practise is to = turn > eg. /var/run/<name>.pid into /var/run/<name>/pid where <name> = directory > has appropriate permissions. Pre-creating pidfiles is simply wrong, > because applications create pidfile on start and unlink it on exit. > If application has no permission to remove files from /var/run/ it = will > leave pidfile with stale PID in it, which is bad. Changing application > to truncate pidfile on exit instead of unlinking it also is a bad idea > especially because there is working solution - pid directory. I prefer this approach, but dougb prefers the other approach. Each has = positives and negatives. I tried to accommodate both approaches. Guy= -------- This message has been scanned by ComplianceSafe, powered by Palisade's PacketSure.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?74AF334B-CD90-4A43-96C4-1CF69C8EA42B>