Date: Wed, 18 May 2016 00:22:52 +0000 (UTC) From: "Pedro F. Giffuni" <pfg@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r300098 - head/usr.sbin/makefs Message-ID: <201605180022.u4I0MqSU048808@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: pfg Date: Wed May 18 00:22:52 2016 New Revision: 300098 URL: https://svnweb.freebsd.org/changeset/base/300098 Log: makefs(8): Clarify the comment concerning seeding. Avoid giving the impression makefs currently supports reproduceable builds. Modified: head/usr.sbin/makefs/ffs.c Modified: head/usr.sbin/makefs/ffs.c ============================================================================== --- head/usr.sbin/makefs/ffs.c Tue May 17 23:15:16 2016 (r300097) +++ head/usr.sbin/makefs/ffs.c Wed May 18 00:22:52 2016 (r300098) @@ -1125,7 +1125,10 @@ ffs_write_inode(union dinode *dp, uint32 initediblk < ufs_rw32(cgp->cg_niblk, fsopts->needswap)) { memset(buf, 0, fs->fs_bsize); dip = (struct ufs2_dinode *)buf; - /* Seeding affects reproducible builds. */ + /* + * XXX: Time-based seeds should be avoided for + * reproduceable builds. + */ srandom(time(NULL)); for (i = 0; i < INOPB(fs); i++) { dip->di_gen = random();
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201605180022.u4I0MqSU048808>