Date: Fri, 24 Jul 2026 11:44:21 -0400 From: Ed Maste <emaste@freebsd.org> To: Mark Johnston <markj@freebsd.org> Cc: Ryan Libby <rlibby@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: caabdb3aefdc - main - contigmalloc.9: Note that M_WAITOK may still return NULL Message-ID: <CAPyFy2CrfOhaaDkvzdVsbO_sJUYEZYyhpSCPB%2BMTL5WRV==PVA@mail.gmail.com> In-Reply-To: <al_m7Jqjcs50QipP@nuc> References: <6a5fba36.3d93d.694b6c5c@gitrepo.freebsd.org> <CAHgpiFwq_m3cS80e-WrBcftvE-M-1zb-0_9L6p5qD_vw139K8w@mail.gmail.com> <al_m7Jqjcs50QipP@nuc>
index | next in thread | previous in thread | raw e-mail
> That said, I think the claim in the man page is actually wrong now. > contigmalloc(M_WAITOK) certainly used to be able to return NULL, but I > think that might no longer be true now that kmem_alloc_contig() is > implemented using domainset iterators. If we try all domains, we'll end > up sleeping and retrying indefinitely, or at least it appears to be that > way. Hmm, contigmalloc does check kmem_alloc_contig's return for NULL, so if this is the case we should probably make that a KASSERT instead.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2CrfOhaaDkvzdVsbO_sJUYEZYyhpSCPB%2BMTL5WRV==PVA>