Date: Sat, 23 Aug 2008 15:29:28 +0000 (UTC) From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/mii mlphy.c tlphy.c Message-ID: <200808231529.m7NFTaiB010725@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
imp 2008-08-23 15:29:28 UTC
FreeBSD src repository
Modified files:
sys/dev/mii mlphy.c tlphy.c
Log:
SVN rev 182064 on 2008-08-23 15:29:28Z by imp
It turns out that my analysis of the error handling here was wrong.
When there's an error, we don't want to free the children, since it
will be stack garbage. While we did fail to dereference it by setting
devs to 0, we didn't fail to call free. We never failed to fail, it
was the easiest thing to do.
Revision Changes Path
1.24 +7 -7 src/sys/dev/mii/mlphy.c
1.24 +2 -3 src/sys/dev/mii/tlphy.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200808231529.m7NFTaiB010725>