Date: Fri, 8 Jun 2018 00:59:51 -0400 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Brad Davis <brd@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334617 - in head: . etc Message-ID: <8BBE4E4C-0E5F-4920-B057-E6F939074448@FreeBSD.org> In-Reply-To: <201806041517.w54FHPn0072477@repo.freebsd.org> References: <201806041517.w54FHPn0072477@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jun 4, 2018, at 11:17, Brad Davis <brd@FreeBSD.org> wrote: >=20 > Author: brd > Date: Mon Jun 4 15:17:24 2018 > New Revision: 334617 > URL: https://svnweb.freebsd.org/changeset/base/334617 >=20 > Log: > Move /sys symlink creating out of etc/Makefile. >=20 > This is prep for etc/Makefile going away. >=20 > Approved by: bapt (mentor) >=20 > Modified: > head/Makefile.inc1 > head/etc/Makefile >=20 Aside from other objections, I don=E2=80=99t think /Makefile nor /Makefile.i= nc1 should =E2=80=9Cown=E2=80=9D anything on the system and should only driv= e the build or other general targets for users to interact with. Please put t= his into something like /hier or better yet the existing directory handling t= hat stuff /etc. (so a revert since simply moving everything to it via a rena= me or rewrite seems silly) > Modified: head/Makefile.inc1 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/Makefile.inc1 Mon Jun 4 14:56:02 2018 (r334616) > +++ head/Makefile.inc1 Mon Jun 4 15:17:24 2018 (r334617) > @@ -1239,6 +1239,7 @@ distributeworld installworld stageworld: _installche= ck > METALOG=3D${METALOG} ${IMAKE_INSTALL} ${IMAKE_MTREE} \ > DISTBASE=3D/base DESTDIR=3D${DESTDIR}/${DISTDIR}/base \ > LOCAL_MTREE=3D${LOCAL_MTREE:Q} distrib-dirs > + ${INSTALL_SYMLINK} usr/src/sys ${DESTDIR}/sys > .endif > ${_+_}cd ${.CURDIR}; ${IMAKE} re${.TARGET:S/world$//}; \ > ${IMAKEENV} rm -rf ${INSTALLTMP} >=20 > Modified: head/etc/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/etc/Makefile Mon Jun 4 14:56:02 2018 (r334616) > +++ head/etc/Makefile Mon Jun 4 15:17:24 2018 (r334617) > @@ -386,7 +386,6 @@ distrib-dirs: ${MTREES:N/*} distrib-cleanup .PHONY > ${METALOG.add} ; \ > done; true > .endif > - ${INSTALL_SYMLINK} usr/src/sys ${DESTDIR}/sys > .if ${MK_NLS} !=3D "no" > set - `grep "^[a-zA-Z]" ${.CURDIR}/nls.alias`; \ > while [ $$# -gt 0 ] ; do \ >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8BBE4E4C-0E5F-4920-B057-E6F939074448>