Date: Sun, 17 Mar 2002 03:07:29 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Bernd Walter <ticso@cicely8.cicely.de> Cc: John Hay <jhay@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org>, "Herbert J. Skuhra" <herbert@bugat.at> Subject: Re: cvs commit: src/sys/dev/sio sio.c sio_isa.c sio_pccard.c sio_pci.c sioreg.h siovar.h Message-ID: <20020317030440.V33393-100000@gamplex.bde.org> In-Reply-To: <20020316144628.GA1170@cicely8.cicely.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 16 Mar 2002, Bernd Walter wrote: > On Wed, Jan 30, 2002 at 09:22:04AM -0800, John Hay wrote: > > jhay 2002/01/30 09:22:04 PST > > > > Modified files: > > sys/dev/sio sio.c sio_isa.c sio_pccard.c sio_pci.c > > sioreg.h siovar.h > > Log: > > Add support for different serial clock frequencies and not just the > > standard one of 1.8432MHz. This will be used by the puc (PCI > > "universal" communication card) device driver. > > This commit breaks my seriel console. > I get a console speed of 1355bps after that. > loader worked fine with 9600bps. > It seems that siocngetspeed read bogus values from my sio. > Now that the sanity checks are removed the value gets used. > Another one on a german list has the same problem with 4.5-stable > and a different board/cpu. How do you select booting with a serial console? The boot program is supposed be using the serial console (if it sets RB_SERIAL at all), and if the device doesn't have read/write registers then other things will break. 0x55 looks like garbage from a probe. > And the remark section for the function claims to return 0 in some > cases which is obsolete now. Also, the check for 0 in the caller is bogus at best. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020317030440.V33393-100000>