Date: Mon, 14 Jun 2010 10:18:24 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Lawrence Stewart <lstewart@freebsd.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r209119 - head/sys/sys Message-ID: <20100614081824.GD1721@garage.freebsd.pl> In-Reply-To: <4C158B71.205@freebsd.org> References: <201006130239.o5D2du3m086332@svn.freebsd.org> <20100613101025.GD1320@garage.freebsd.pl> <4C158B71.205@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Mon, Jun 14, 2010 at 11:52:49AM +1000, Lawrence Stewart wrote:
> Given that the DPCPU variable name space is flat and variable names have
> to be unique, perhaps something like the following would address the
> concerns raised?
>
> #define DPCPU_SUM(n, var, sum) \
> do { \
> u_int _##n##_i; \
> (sum) = 0; \
> CPU_FOREACH(_##n##_i) \
> (sum) += (DPCPU_ID_PTR(_##n##_i, n))->var; \
> } while (0)
Looks ok to me. Thanks.
--
Pawel Jakub Dawidek http://www.wheelsystems.com
pjd@FreeBSD.org http://www.FreeBSD.org
FreeBSD committer Am I Evil? Yes, I Am!
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)
iEYEARECAAYFAkwV5dAACgkQForvXbEpPzRi8ACeOOvgs4zqQjgjGClp8ALd1+qc
KyIAnilq2IcbhWN7CRwnIkvryaQuqNRv
=3ps0
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100614081824.GD1721>