Date: Sun, 13 Oct 2013 04:40:58 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: current@FreeBSD.org Cc: swills@FreeBSD.org, remko@FreeBSD.org Subject: Problems with rc.d/jail change (Re: svn commit: r256256 - in head: . etc etc/defaults etc/rc.d share/man/man5 usr.sbin/jail) Message-ID: <20131013.044058.1382656329747589715.hrs@allbsd.org> In-Reply-To: <4B2ECC28-4F63-448A-B99E-DC5215C5FFD0@freebsd.org> References: <DE0D956D-A1E5-48D2-8886-63F954910075@FreeBSD.org> <20131011141214.GA91989@mouf.net> <4B2ECC28-4F63-448A-B99E-DC5215C5FFD0@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart0(Sun_Oct_13_04_40_58_2013_802)--
Content-Type: Multipart/Mixed;
boundary="--Next_Part(Sun_Oct_13_04_40_58_2013_119)--"
Content-Transfer-Encoding: 7bit
----Next_Part(Sun_Oct_13_04_40_58_2013_119)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Remko Lodder <remko@freebsd.org> wrote
in <4B2ECC28-4F63-448A-B99E-DC5215C5FFD0@freebsd.org>:
re>
re> On Oct 11, 2013, at 4:12 PM, Steve Wills <swills@FreeBSD.org> wrote:
re>
re> > I'm having the same issue.
re>
re> I am working with Hiroki to resolve this. So far his work seems to fix
re> this, he will commit that as soon as we can reasonable think
re> that this is OK (and it looks that way :))
Let me summarize what I noticed so far:
(1) A jail with jail_fdescfs_enable="YES" fails to start.
(2) A jail with multiple parameters in jail_parameters="..." fails
to start.
(1) was fixed in r256385. The attached patch should fix (2). Please
try it if you still have a problem.
Jail configurations can be complex, so there may be some more cases
which break the old behaviors. Please send me your report if you
have differences between before and after the rc.d/jail change.
-- Hiroki
----Next_Part(Sun_Oct_13_04_40_58_2013_119)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline; filename="jail_20131013-1.diff"
Index: etc/rc.d/jail
===================================================================
--- etc/rc.d/jail (revision 256385)
+++ etc/rc.d/jail (working copy)
@@ -94,7 +94,7 @@
#
parse_options()
{
- local _j
+ local _j _p
_j=$1
_confwarn=0
@@ -234,7 +234,9 @@
"\"procfs ${_rootdir%/}/proc procfs rw 0 0\";"
fi
- echo " ${_parameters};"
+ for _p in $_parameters; do
+ echo " ${_p%\;};"
+ done
eval : \${jail_${_j}_mount_enable:=${jail_mount_enable:-NO}}
if checkyesno jail_${_j}_mount_enable; then
----Next_Part(Sun_Oct_13_04_40_58_2013_119)----
----Security_Multipart0(Sun_Oct_13_04_40_58_2013_802)--
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (FreeBSD)
iEYEABECAAYFAlJZpcoACgkQTyzT2CeTzy3EsACfX+GXWCd2KLwXnY81fpLJAyDv
dvQAoLHiNhZtA1zFWHbmqCOTCzkGtK/m
=OsnO
-----END PGP SIGNATURE-----
----Security_Multipart0(Sun_Oct_13_04_40_58_2013_802)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131013.044058.1382656329747589715.hrs>