Date: Fri, 29 Jun 2012 10:35:59 -0700 (PDT) From: Pedro Giffuni <pfg@freebsd.org> To: obrien@FreeBSD.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r237624 - in head: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantize cddl/contrib/opensolaris/lib/libdtrace/common sys/cddl/contrib/opensolaris/uts/common/dtrace sys/cddl/c... Message-ID: <1340991359.60778.YahooMailClassic@web113502.mail.gq1.yahoo.com> In-Reply-To: <20120629152109.GA70522@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
(Sorry for top-posting]=0A=0AActually ...=0A=0ADavid pointed out a fundamen= tal flaw on my part.=0A=0AThese are new files under a non-BSD license. Even= when=0Athey are only scripts used for testing I shouldn't have=0Abrought t= hem in without -core approval.=0A=0AI will delete them right away and core = shall decide=0Aafterwards if and how they can be brought in.=0A=0APedro.=0A= =0A=0A--- Ven 29/6/12, David O'Brien <obrien@FreeBSD.org> ha scritto:=0A=0A= > Da: David O'Brien <obrien@FreeBSD.org>=0A> Oggetto: Re: svn commit: r2376= 24 - in head: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantiz= e cddl/contrib/opensolaris/lib/libdtrace/common sys/cddl/contrib/opensolari= s/uts/common/dtrace sys/cddl/c...=0A> A: "Pedro F. Giffuni" <pfg@FreeBSD.or= g>=0A> Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-hea= d@FreeBSD.org=0A> Data: Venerd=EC 29 giugno 2012, 10:21=0A> On Wed, Jun 27,= 2012 at 04:39:30AM=0A> +0000, Pedro F. Giffuni wrote:=0A> > Log:=0A> >=A0= =A0=A0Bring llquantize support into Dtrace.=0A> >=A0=A0=A0Bryan Cantrill im= plemented the=0A> equivalent of semi-log graph=0A> >=A0=A0=A0paper for Dtra= ce so llquantize will=0A> use one logarithmic and=0A> >=A0=A0=A0one linear = scale.=0A> ...=0A> >=A0=A0=A0Obtained from:=A0=A0=A0=0A> Illumos=0A> ...=0A= > > Added:=0A> head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llq= uantize/err.D_LLQUANT_FACTOREVEN.nodivide.d=0A> >=0A> =3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A> > --- /= dev/null=A0=A0=A0 00:00:00=0A> 1970=A0=A0=A0 (empty, because file is newly = added)=0A> > +++=0A> head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/comm= on/llquantize/err.D_LLQUANT_FACTOREVEN.nodivide.d=A0=A0=A0=0A> Wed Jun 27 0= 4:39:30 2012=A0=A0=A0 (r237624)=0A> > @@ -0,0 +1,29 @@=0A> > +/*=0A> > + * = CDDL HEADER START=0A> > + *=0A> > + * The contents of this file are subject= to the terms=0A> of the=0A> > + * Common Development and Distribution Lice= nse (the=0A> "License").=0A> > + * You may not use this file except in comp= liance with=0A> the License.=0A> ...=0A> > +/*=0A> > + * Copyright (c) 2011= , Joyent, Inc. All rights=0A> reserved.=0A> > + */=0A> =0A> Pedro,=0A> It l= ooks like you simply 'svn add'ed this file, rather than=0A> importing it=0A= > into '^/vendor/opensolaris/dist'.=A0 Please correct me if=0A> I am wrong.= =0A> =0A> We've become rather sloppy in the past 1-2 years in our=0A> handl= ing of=0A> 3rd-party externally developed code.=A0 Something we need=0A> to= return to=0A> our older ways good ways of handling.=0A> =0A> This is somet= hing that is especially important with GPL,=0A> CDDL, and=0A> similar licen= ses.=0A> =0A> Commercial entities that base products on FreeBSD have to=0A>= worry about=0A> code provenance for various intellectual property legal=0A= > reasons and we=0A> muddy the waters when we make it harder to track who a= nd=0A> where code came=0A> from.=0A> [Please see http://www.osgeo.org/incub= ator/process/codereview.html=0A> &=0A> http://wiki.osgeo.org/wiki/Code_Prov= enance_Review to=0A> better understand=0A> this issue.]=0A> =0A> Not follow= ing our established procedure also means that the=0A> average=0A> developer= (committer) and commercial consumer will have their=0A> expectations=0A> fa= il.=A0 One expects to be able to find the stock vendor=0A> sources in=0A> s= sh://svn.freebsd.org/base/vendor/ and to be able to find=0A> FreeBSD local= =0A> changes to the sources thru 'svn diff' against=0A> 'ssh://svn.freebsd.= org/base/head'.=0A> =0A> Please correct this by properly importing the sour= ces, 'svn=0A> delete'ing=0A> the files you 'svn add'ed, and do an 'svn copy= ' of the new=0A> files.=0A> =0A> thanks,=0A> -- =0A> -- David=A0 (obrien@Fr= eeBSD.org)=0A>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1340991359.60778.YahooMailClassic>