Date: Sat, 11 Jan 2003 21:19:32 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: Alfred Perlstein <bright@mu.org> Cc: Jake Burkholder <jake@locore.ca>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_acl.c kern_descrip.c kern_event.c kern_mac.c sys_pipe.c sys_socket.c uipc_socket.c uipc_syscalls.c uipc_usrreq.c vfs_aio.c vfs_syscalls.c vfs_vnops.c src/sys/netgraph ng_socket.c src/sys/sys file.h src/sys/ufs/ffs ... Message-ID: <200301120519.h0C5JW9b056231@apollo.backplane.com> References: <200301120137.h0C1bD0E098037@repoman.freebsd.org> <20030111213259.E212@locore.ca> <200301120254.h0C2srcS043241@apollo.backplane.com> <20030112040835.GA33821@elvis.mu.org> <200301120459.h0C4xV5a052068@apollo.backplane.com> <20030112050811.GB33821@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
:> the field is a union.
:>
:> I have no problem changing the name but we can't call the
:> union f_data (we need to leave f_data open to catch source code
:> incompatibilities and to possibly use as a kernelland #define for
:> compatibility). We would have to think up of another name.
:
:Not really, if you keep it as f_data then people will not be able
:to compile code as they will get an error, that is unless they
:take the address of it, but that behavior is ok.
:
:using fd_ or fdata_ or filedata_ for the union members would be acceptable
:afaik.
Uh, that's making a lot of assumptions. I prefer more determinisitic
compile-time errors. I am not going to name it f_data. How about
something like f_opaque ? That's nice an obvious. f_opaque.vnode,
f_opaque.kqueue, etc.
-Matt
Matthew Dillon
<dillon@backplane.com>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200301120519.h0C5JW9b056231>