Date: Thu, 1 Dec 2005 14:38:11 -0500 From: Garance A Drosehn <gad@FreeBSD.org> To: Ruslan Ermilov <ru@FreeBSD.org>, Warner Losh <imp@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 Message-ID: <p06230900bfb4fa9993bf@[128.113.24.47]> In-Reply-To: <20051201172757.GG20961@ip.net.ua> References: <200512011708.jB1H8u3Y065515@repoman.freebsd.org> <20051201172757.GG20961@ip.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
At 7:27 PM +0200 12/1/05, Ruslan Ermilov wrote:
>On Thu, Dec 01, 2005 at 05:08:56PM +0000, Warner Losh wrote:
>> imp 2005-12-01 17:08:56 UTC
>>
>> FreeBSD src repository
>>
>> Modified files:
>> . Makefile.inc1
>> Log:
> > In make buildenv, spell sh as ${SHELL}. In this case, we don't
> > want to hard code /bin/sh since we're forking it for the user
> > to type commands into. As such, ${SHELL} is the preferred
> > thing users type commands into.
>
>Please consider backing it out. In this case, we want to hard code
>it to "sh" since the stock ~root/.cshrc always resets $PATH, which
>breaks "make buildenv" for root (which most of us use).
> Testcase: "which cc" from under "make buildenv" shell.
Hmm. How about:
BUILDENVSHELL?=sh
buildenv:
@echo Entering world for ${TARGET_ARCH}:${TARGET}
@cd ${.CURDIR} && env ${WMAKEENV} ${BUILDENVSHELL} || true
--
Garance Alistair Drosehn = gad@gilead.netel.rpi.edu
Senior Systems Programmer or gad@FreeBSD.org
Rensselaer Polytechnic Institute; Troy, NY; USA
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p06230900bfb4fa9993bf>