Date: Mon, 8 Nov 1999 15:23:47 -0700 (MST) From: "Kenneth D. Merry" <ken@kdm.org> To: jlemon@americantv.com (Jonathan Lemon) Cc: des@flood.ping.uio.no (Dag-Erling Smorgrav), current@freebsd.org Subject: Re: TCP sockets stuck in the CLOSING state Message-ID: <199911082223.PAA10608@panzer.kdm.org> In-Reply-To: <19991107080903.23572@right.PCS> from Jonathan Lemon at "Nov 7, 1999 08:09:03 am"
next in thread | previous in thread | raw e-mail | index | archive | help
Jonathan Lemon wrote... > On Nov 11, 1999 at 01:41:48PM +0100, Dag-Erling Smorgrav wrote: > > Note that the state transition diagram in RFC793 does not specify a > > timeout for the CLOSING -> TIME_WAIT transition, so any faithful > > implementation of RFC793 has this bug (but why doesn't this happen on > > -STABLE, or on pre-August -CURRENT?) > > I'm not sure abuot that one. But I've just committed a fix to tcp_fsm.h, > which will cause it to re-transmit a FIN in CLOSING state. The FIN was > originally taken out by Garrett in rev 1.5, and restored by dg in rev 1.6. > However, it was re-removed in 1.10 when Garrett made a large commit, > presumably he hadn't taken it out of his local tree. > > It fixes the problem here (at least, I can't replicate the problem any > more). I'm not sure if I'm fixing the symptoms rather than the actual > problem then, though. NetBSD has the same fix in their tree as well. I've had the fix in use for about a day, and it seems to fix the problem here. I don't have any sockets stuck in the CLOSING state, and from previous experience, I would have at least one or two by now. > I'm pretty sure that I've seen this problem on -current going back as > early as March as well. I don't remember it happening before, but of course that doesn't mean it didn't happen. There's a guy who reported the same problem with -stable on the -isp list. I sent him the patch, and told him to report back to you and the -stable list on whether or not it works. He said that he did not have the problem with 2.2.x machines. If it's happening with -stable, that means the problem has been in the tree for a while (probably since rev 1.10, which was in 1997) and may have just been exacerbated somehow by the timer changes in August. Ken -- Kenneth Merry ken@kdm.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199911082223.PAA10608>