Date: Sat, 17 Jun 2006 22:48:34 +0000 (UTC) From: Robert Watson <rwatson@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern uipc_socket2.c src/sys/sys socketvar.h Message-ID: <200606172248.k5HMmYwR023222@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
rwatson 2006-06-17 22:48:34 UTC
FreeBSD src repository
Modified files:
sys/kern uipc_socket2.c
sys/sys socketvar.h
Log:
Remove sbinsertoob(), sbinsertoob_locked(). They violate (and have
basically always violated) invariannts of soreceive(), which assume
that the first mbuf pointer in a receive socket buffer can't change
while the SB_LOCK sleepable lock is held on the socket buffer,
which is precisely what these functions do. No current protocols
invoke these functions, and removing them will help discourage them
from ever being used. I should have removed them years ago, but
lost track of it.
MFC after: 1 week
Prodded almost by accident by: peter
Revision Changes Path
1.158 +0 -64 src/sys/kern/uipc_socket2.c
1.150 +0 -2 src/sys/sys/socketvar.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200606172248.k5HMmYwR023222>