Date: Wed, 7 Jul 2010 12:13:53 +0930 From: "Daniel O'Connor" <doconnor@gsoft.com.au> To: Jeremy Chadwick <freebsd@jdc.parodius.com> Cc: FreeBSD Stable <freebsd-stable@freebsd.org>, freebsd-ports@freebsd.org Subject: Re: MIMEDefang not starting on reboot Message-ID: <4BB8A521-E50D-4A0C-AEBA-6883BFD5846B@gsoft.com.au> In-Reply-To: <20100707024217.GA77748@icarus.home.lan> References: <F6F09CC9-410D-4353-9C52-AB9BE7D29CD3@gsoft.com.au> <20100707024217.GA77748@icarus.home.lan>
index | next in thread | previous in thread | raw e-mail
On 07/07/2010, at 12:12, Jeremy Chadwick wrote: >> --- /usr/local/etc/rc.d/mimedefang.sh-dist 2010-04-07 10:30:46.586067014 +0930 >> +++ /usr/local/etc/rc.d/mimedefang.sh 2010-05-01 13:47:47.340517685 +0930 >> @@ -316,7 +319,7 @@ >> rm -f $MX_SOCKET > /dev/null 2>&1 >> rm -f $SOCKET > /dev/null 2>&1 >> >> - if [ "$1" = "wait" ] ; then >> + if [ "wait" = "wait" ] ; then >> printf "Waiting for daemons to exit." >> WAITPID="" >> test -f $PID && WAITPID=`cat $PID` >> >> Otherwise restart is useless because it starts MD without waiting for the old one to stop and it doesn't work :( > > This should probably go to freebsd-ports not -stable, since both > mimedefang and perl are ports things. CC'ing. True. > Also, that patch doesn't look correct, or you got your diff arguments > backwards (e.g. change should be fixing the wait=wait comparison to > use $1=wait). No, really, I want it to always succeed. The optional wait appears to be a Linux thing, however rc.d scripts on FreeBSD [should] always wait for their daemons to exit, otherwise restart will try and start it before it has exited. -- Daniel O'Connor software and network engineer for Genesis Software - http://www.gsoft.com.au "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8Chome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BB8A521-E50D-4A0C-AEBA-6883BFD5846B>