Date: Wed, 20 Sep 2000 20:18:02 -0700 From: "James Johnson" <bonk1138@msn.com> To: <FreeBSD-gnats-submit@freebsd.org> Subject: bin/21436: pkg_install will not compile w/o warnings Message-ID: <KJEDKFEKMMFFMPFPBLJHEEDPDBAA.bonk1138@msn.com>
next in thread | raw e-mail | index | archive | help
>Number: 21436
>Category: bin
>Synopsis: pkg_install will not compile without errors
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Sep 20 20:20:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator: James Johnson
>Release: FreeBSD 5.0-CURRENT i386
>Organization:
NonYa
>Environment:
FreeBSD obiwan 5.0-CURRENT FreeBSD 5.0-CURRENT #1: Tue Sep 19 00:22:29 PDT
2000 jsj@obiwan:/usr/obj/usr/src2/src/sys/obiwan i386
>Description:
Attempting to compile usr.sbin/pkg_install with -Werror and -Wall
will fail
>How-To-Repeat:
Try compiling usr.sbin/pkg_install with -Wall and -Werror
>Fix:
Index: extract.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/pkg_install/add/extract.c,v
retrieving revision 1.25
diff -u -r1.25 extract.c
--- extract.c 1999/08/28 01:17:55 1.25
+++ extract.c 2000/09/21 03:08:27
@@ -249,6 +249,14 @@
case PLIST_IGNORE:
p = p->next;
break;
+ case PLIST_UNEXEC:
+ case PLIST_SRC:
+ case PLIST_DISPLAY:
+ case PLIST_PKGDEP:
+ case PLIST_MTREE:
+ case PLIST_DIR_RM:
+ case PLIST_IGNORE_INST:
+ case PLIST_OPTION:
}
p = p->next;
}
Index: file.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/pkg_install/lib/file.c,v
retrieving revision 1.43
diff -u -r1.43 file.c
--- file.c 2000/09/18 07:41:48 1.43
+++ file.c 2000/09/21 03:09:16
@@ -142,14 +142,12 @@
char *
fileGetURL(char *base, char *spec)
{
- char host[HOSTNAME_MAX], file[FILENAME_MAX];
- char pword[HOSTNAME_MAX + 40], *uname, *cp, *rp;
+ char *cp, *rp;
char fname[FILENAME_MAX];
char pen[FILENAME_MAX];
- struct passwd *pw;
FILE *ftp;
pid_t tpid;
- int i, status;
+ int i;
char *hint;
rp = NULL;
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?KJEDKFEKMMFFMPFPBLJHEEDPDBAA.bonk1138>