Date: Wed, 13 Jan 2016 12:13:10 +0800 From: Marcelo Araujo <araujobsdport@gmail.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org> Subject: Re: svn commit: r405766 - head/print/abcm2ps Message-ID: <CAOfEmZhtfwV6aSmS7Ou4a-CkyMnzYWw-KALkRxMK_ik8YfuQ6g@mail.gmail.com> In-Reply-To: <20160113040225.GB42704@FreeBSD.org> References: <201601110721.u0B7LJHD048438@repo.freebsd.org> <20160111082634.GA7288@FreeBSD.org> <20160113040225.GB42704@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, Please, would be good if you can send a patch. Best, 2016-01-13 12:02 GMT+08:00 Alexey Dokuchaev <danfe@freebsd.org>: > On Mon, Jan 11, 2016 at 08:26:34AM +0000, Alexey Dokuchaev wrote: > > On Mon, Jan 11, 2016 at 07:21:19AM +0000, Marcelo Araujo wrote: > > > New Revision: 405766 > > > URL: https://svnweb.freebsd.org/changeset/ports/405766 > > > > > > Log: > > > - Update to 8.10.0. > > > - USE_GCC yes. > > > > There are several problems with this commit. On the surface, it does not > > explain the reason for USE_GCC. Secondly, even with USE_GCC=yes it still > > does no build, due to "CC = gcc" line in the $wrksrc/Makefile. Also, the > > Sorry for confusion: apparently it builds with USE_GCC unless `lang/gcc48' > port is installed, which satisfies "depends on executable: gcc48 - found", > but doesn't install unversioned symlink (available since r402352 2015-11-24 > in `lang/gcc' itself -- older packages would also fail). > > That said, pulling GCC just because it provides `gcc' command looks bogus. > > > port does not uphold CFLAGS (and CC, obviously). > > > > Consider the following pseudo-patch: > > > > -USE_GCC= yes > > +MAKE_ARGS= CC="${CC}" CFLAGS="${CFLAGS}" > > If you prefer, I can send a real patch. > > ./danfe > -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>; \/ \ ^ Power To Server. .\. /_)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZhtfwV6aSmS7Ou4a-CkyMnzYWw-KALkRxMK_ik8YfuQ6g>