Date: Sat, 21 Sep 2024 13:42:33 GMT From: Mark Johnston <markj@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 7cfdb02a73df - main - bhyve: Fix an inverted check when enabling PCI busmastering Message-ID: <202409211342.48LDgXQC078470@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=7cfdb02a73df33d33952119c87f3e12f12778360 commit 7cfdb02a73df33d33952119c87f3e12f12778360 Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2024-09-21 13:15:26 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2024-09-21 13:42:15 +0000 bhyve: Fix an inverted check when enabling PCI busmastering Reported by: Andy Fiddaman <andy@omniosce.org> Fixes: e962b37bf0ff ("bhyve: Do not enable PCI BAR decoding if a boot ROM is present") --- usr.sbin/bhyve/pci_emul.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/bhyve/pci_emul.c b/usr.sbin/bhyve/pci_emul.c index e066d6766f3c..b61f29aa6830 100644 --- a/usr.sbin/bhyve/pci_emul.c +++ b/usr.sbin/bhyve/pci_emul.c @@ -1160,7 +1160,7 @@ pci_emul_init(struct vmctx *ctx, struct pci_devemu *pde, int bus, int slot, pci_set_cfgdata8(pdi, PCIR_INTLINE, 255); pci_set_cfgdata8(pdi, PCIR_INTPIN, 0); - if (!get_config_bool_default("pci.enable_bars", !bootrom_boot())) + if (get_config_bool_default("pci.enable_bars", !bootrom_boot())) pci_set_cfgdata8(pdi, PCIR_COMMAND, PCIM_CMD_BUSMASTEREN); err = (*pde->pe_init)(pdi, fi->fi_config);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202409211342.48LDgXQC078470>