Date: Mon, 07 Feb 2005 15:32:31 +0100 From: =?UTF-8?B?U8O4cmVuIFNjaG1pZHQ=?= <sos@DeepCore.dk> To: Arne Schwabe <arne@rfc2549.org> Cc: freebsd-stable@freebsd.org Subject: Re: ATA mkIII first official patches - please test! Message-ID: <42077BFF.8060908@DeepCore.dk> In-Reply-To: <86oeewsaw8.fsf@kamino.rfc1149.org> References: <42028F29.1030801@DeepCore.dk> <20050206.214325.85708834.rushani@bl.mmtr.or.jp> <42061B9F.6080300@DeepCore.dk> <16903.29857.72896.98582@ran.psg.com> <42077563.9040002@DeepCore.dk> <86oeewsaw8.fsf@kamino.rfc1149.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Arne Schwabe wrote:
> Søren Schmidt <sos@DeepCore.dk> writes:
>
>
>>Randy Bush wrote:
>>
>>>>>After suspend, my ThinkPad X40 now hangs with following logs (copied
>>>>>by hand):
>>>>
>>>>Hmm, do you have ATA compiled in or as modules. I could easily
>>>>imagine that modules could have problems, but as "built in" nothing
>>>>really changed...
>>>
>>>my patched t41, current with ata in the kernel, locks up with disk
>>>light on solid on resume.
>>
>>Does it work with stock ATA ?
>>I cant work on suspend/resume as it has been broken due to ACPI
>>brokenness since september last year on all my laptops...
>
>
> Same here, worked before the patch. Does not work with the patch.
Hmm, the attached patch is the only real difference, which actually
shouldn't pose a problem (and fixes broken APM)..
Let me know if that changes anything, other than that you are free to
bug the ACPI gang to make ACPI work on the HW I have available for
development...
-Søren
[-- Attachment #2 --]
diff -u -r1.20 ata-all.c
--- ata-all.c 2005/02/03 17:02:31 1.20
+++ ata-all.c 2005/02/07 14:27:57
@@ -630,7 +630,7 @@
void
ata_udelay(int interval)
{
- if (1 || interval < (1000000/hz) || ata_delayed_attach)
+ if (interval < (1000000/hz) || ata_delayed_attach)
DELAY(interval);
else
tsleep(&interval, PRIBIO, "ataslp", interval/(1000000/hz));
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42077BFF.8060908>