Date: Fri, 25 Oct 2013 13:14:39 -0700 From: Adrian Chadd <adrian.chadd@gmail.com> To: Sean Bruno <sbruno@freebsd.org> Cc: "freebsd-wireless@freebsd.org" <freebsd-wireless@freebsd.org> Subject: Re: [iwn] request to test: linkq, plcp, txrate fixes Message-ID: <CAJ-Vmok7s4VvgJG=au8D7NqyHFaxTE7JJgS_vCfvsm-PBjW3Wg@mail.gmail.com> In-Reply-To: <1382662196.2498.1.camel@localhost> References: <CAJ-VmokLJX7Mjt=7VrPrecS8odycGPOzz=knMXVckip_TTHdqw@mail.gmail.com> <1382662196.2498.1.camel@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
Just committed it to -HEAD. -adrian On 24 October 2013 17:49, Sean Bruno <sean_bruno@yahoo.com> wrote: > On Thu, 2013-10-24 at 13:04 -0700, Adrian Chadd wrote: > > Hi! > > > > I have a patch against iwn(4): > > > > > http://people.freebsd.org/~adrian/ath/20131024-iwn-1-fix-xmit-rate-plcp-linkq.diff > > > > This does a few things: > > > > * The multi-rate retry ("link quality" stuff) on iwn is a table, and I > > think I broke it slightly when I implemented 11n rate control. This > > disables it for now, at least until I / someone implements a replacement > > table setup and linkq decision. > > > > * get rid of the rate index stuff - it was used to decide a few things > and > > it was doing legacy-only rate index lookups. I've just removed it; it's > not > > needed. > > > > * Teach the raw transmit path to use the new plcp lookup routine that > sets > > things up. > > > > * Correctly implement 11g protection. Right now it was a bit of a hack > and > > it was not correct for 11a or 11n operation. > > > > I still get transmit hangs on my 4965 but the "invalid rate" failures > have > > disappeared. But for some odd reason, the transmits completed but weren't > > being marked as failed. I don't yet know why. > > > > I'm also not sure why transmit is hanging; sometimes it looks like DMA > > stalls somehow. > > > > So - maybe this'll help with various 11n issues on iwn(4), maybe it > won't. > > I'm not sure yet. I'm trying to avoid taking ownership of iwn(4) but I > > rather dislike the occasional 5100/4965 hangs.. > > > > Thanks, > > > > > > > > -adrian > > running this now against 11-CURRENT. No issues noted on my adapter > (Centrino Advanced-N 6205 [Taylor Peak]). All seems very good. > > I haven't tried it the office though, and that's the one that's the most > interesting I fear. > > sean >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmok7s4VvgJG=au8D7NqyHFaxTE7JJgS_vCfvsm-PBjW3Wg>