Date: Wed, 19 Jan 2022 17:50:32 GMT From: Robert Wing <rew@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 51fbd894ddad - main - bhyve/snapshot: fix pthread_create() error check Message-ID: <202201191750.20JHoW0C085916@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by rew: URL: https://cgit.FreeBSD.org/src/commit/?id=51fbd894ddadd6a1bc4cb72de8ac4e92c013bd36 commit 51fbd894ddadd6a1bc4cb72de8ac4e92c013bd36 Author: Robert Wing <rew@FreeBSD.org> AuthorDate: 2022-01-19 17:40:06 +0000 Commit: Robert Wing <rew@FreeBSD.org> CommitDate: 2022-01-19 17:40:06 +0000 bhyve/snapshot: fix pthread_create() error check pthread_create() returns 0 on success or an error number on failure. Reviewed by: khng, markj Differential Revision: https://reviews.freebsd.org/D33930 --- usr.sbin/bhyve/snapshot.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/usr.sbin/bhyve/snapshot.c b/usr.sbin/bhyve/snapshot.c index 1a06c3e8d065..4c2cbed2c143 100644 --- a/usr.sbin/bhyve/snapshot.c +++ b/usr.sbin/bhyve/snapshot.c @@ -1520,7 +1520,7 @@ init_checkpoint_thread(struct vmctx *ctx) int socket_fd; pthread_t checkpoint_pthread; char vmname_buf[MAX_VMNAME]; - int ret, err = 0; + int err; memset(&addr, 0, sizeof(addr)); @@ -1555,12 +1555,10 @@ init_checkpoint_thread(struct vmctx *ctx) checkpoint_info->ctx = ctx; checkpoint_info->socket_fd = socket_fd; - ret = pthread_create(&checkpoint_pthread, NULL, checkpoint_thread, + err = pthread_create(&checkpoint_pthread, NULL, checkpoint_thread, checkpoint_info); - if (ret < 0) { - err = ret; + if (err != 0) goto fail; - } return (0); fail:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202201191750.20JHoW0C085916>