Date: Wed, 26 Apr 2023 13:22:45 -0700 From: John Baldwin <jhb@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 2d7842d0bfb4 - main - arp/ndp: Use valid prototypes for function declarations with no arguments. Message-ID: <8edff70f-c09f-462c-5821-cb44aebc4723@FreeBSD.org> In-Reply-To: <202304262019.33QKJ2hF081036@gitrepo.freebsd.org> References: <202304262019.33QKJ2hF081036@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/26/23 1:19 PM, John Baldwin wrote: > The branch main has been updated by jhb: > > URL: https://cgit.FreeBSD.org/src/commit/?id=2d7842d0bfb4257c5b1aba5c1e6f79e47735d71c > > commit 2d7842d0bfb4257c5b1aba5c1e6f79e47735d71c > Author: John Baldwin <jhb@FreeBSD.org> > AuthorDate: 2023-04-26 20:18:53 +0000 > Commit: John Baldwin <jhb@FreeBSD.org> > CommitDate: 2023-04-26 20:18:53 +0000 > > arp/ndp: Use valid prototypes for function declarations with no arguments. > --- > usr.sbin/arp/arp_netlink.c | 2 +- > usr.sbin/ndp/ndp_netlink.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) There is not a valid reason for writing new 1980's C code in 2023. It's one thing to be updating legacy code to use proper function prototypes. It's another thing to be comitting brand new code to the tree that's from the stone age. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8edff70f-c09f-462c-5821-cb44aebc4723>