Date: Fri, 31 Jan 2003 14:55:58 -0800 (PST) From: Julian Elischer <julian@elischer.org> To: Scott Long <scott_long@btc.adaptec.com> Cc: John Baldwin <jhb@freebsd.org>, cvs-committers@freebsd.org, cvs-all@freebsd.org, "Tim J. Robbins" <tjr@freebsd.org> Subject: Re: cvs commit: src/sys/kern subr_trap.c Message-ID: <Pine.BSF.4.21.0301311430200.47169-100000@InterJet.elischer.org> In-Reply-To: <3E3AF6FD.4000904@btc.adaptec.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 31 Jan 2003, Scott Long wrote: > Julian Elischer wrote: > > Julian, > > I think that you are missing the point of being a MENTOR. This wasn't a > random developer coming to you for a review, and the result being a > simple miscommunication. This was your mentee, whom you assume > responsibility for. Being a mentor is more than being a sponsor. The > intent was that if the mentee screws up, the mentor takes responsibility > publically, and hopefully that would encourage the mentor to be as > active and careful as possible. I have to agree with others that trying > to absolve yourself here is inappropriate and downright unfair to David. > > Without picking on David, I think that this is a perfect example of the > grumbling that has been building about the lessening quality of people's > work. Would a forced backout send the message that untested and broken > commits are not acceptable? I'm reluctant to lower the axe while David > is away, but it's put us in a bad position. I've said that as far as I know this was a misunderstanding. I have tried to the best of my ability to mitigate the problems that came up because I feel some responsibility due to fact that I am supposed to be the mentor. However the biggest problems I have seen is that there have been several of problems that people have seen but NONE of them was reported to me directly. I heard of problems with other architectures through Robert who refered to lots of complaints, non of which I had seen, and I heard about the problem in thread_statclock from John, who was repeating comments made by someone else. I have (now) gone through the patch and I can not see any further problems. If you do back it out in david's absense, I will not be adding any more evaluation of the patch. I've already done that. So don't back it out expecting me to do more reviewing of it. It's now at the stage it would be at had it been delayed for me to review it and test such things as profiling. My comment about not reading was because John accused me of letting it be committed without testing, and I'm saying that I DID NOT LET IT BE COMMITTED. David mistook somethign I said to be my permission to commit, but the commit caught me as much by surprise as anyone else. I was expecting another few rounds of discussion in the KSE list before that. Now that it is in, and I have looked at it as closely as I should have looked at it before it was committed, I'm not sure that backing it out will achieve anyuthing. David isn't here to look at it, and as far as I know (unless there are more secret discussions on IRC ;-) it is working fine now thanks to tim for finding the 'ticks' problem. Hindsite is a wonderful thing. but we need to look forward, not backwards. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0301311430200.47169-100000>