Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 19 Apr 2021 19:37:50 GMT
From:      Kevin Bowling <kbowling@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: deecaa144526 - main - ixgbe: Clean up unneeded set in ixgbe_if_multi_set
Message-ID:  <202104191937.13JJbo5J027734@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by kbowling (ports committer):

URL: https://cgit.FreeBSD.org/src/commit/?id=deecaa144526a5d001aeb99149e2139601388427

commit deecaa144526a5d001aeb99149e2139601388427
Author:     Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2021-04-19 19:22:22 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2021-04-19 19:37:30 +0000

    ixgbe: Clean up unneeded set in ixgbe_if_multi_set
    
    We don't need to set the bits here since the if/else if/else statements
    fully cover setting these bit pairs.
    
    Reported by:    markj
    Reviewed by:    markj, erj
    Approved by:    #intel_networking
    MFC aftter:     1 week
    Differential Revision:  https://reviews.freebsd.org/D29827
---
 sys/dev/ixgbe/if_ix.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c
index 77ef118493a2..a483fe503c7f 100644
--- a/sys/dev/ixgbe/if_ix.c
+++ b/sys/dev/ixgbe/if_ix.c
@@ -3294,7 +3294,7 @@ ixgbe_if_multi_set(if_ctx_t ctx)
 	    adapter);
 
 	fctrl = IXGBE_READ_REG(&adapter->hw, IXGBE_FCTRL);
-	fctrl |= (IXGBE_FCTRL_UPE | IXGBE_FCTRL_MPE);
+
 	if (ifp->if_flags & IFF_PROMISC)
 		fctrl |= (IXGBE_FCTRL_UPE | IXGBE_FCTRL_MPE);
 	else if (mcnt >= MAX_NUM_MULTICAST_ADDRESSES ||



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202104191937.13JJbo5J027734>