Date: Sun, 16 Jul 2000 17:12:35 -0600 From: Warner Losh <imp@village.org> To: Matt Dillon <dillon@earth.backplane.com> Cc: "Jordan K. Hubbard" <jkh@zippy.osd.bsdi.com>, Peter Wemm <peter@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/usbd usbd.c Message-ID: <200007162312.RAA56337@harmony.village.org> In-Reply-To: Your message of "Sun, 16 Jul 2000 15:48:53 PDT." <200007162248.PAA09181@earth.backplane.com> References: <200007162248.PAA09181@earth.backplane.com> <2076.963534850@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200007162248.PAA09181@earth.backplane.com> Matt Dillon writes: : : :> Correct an additional off-by-one bug and buffer overflow. A malloc() : :> was being made one byte too short, and the string assembled in it was not : :> null terminated. The string was passed to regcomp() so it never matched : :> anything in /etc/usbd.conf. This is the cause of usbd not working for the : :> last few days.. The new malloc.conf default of AJ triggered this. : : : :Oh god, did you have to say that? Now phk will be INSUFFERABLE for : :weeks. :-) : : : :- Jordan : : AJ ? Guys, 'J' as a default to malloc.conf is a disaster for performance. : There are many programs which allocate large buffers and only use : small portions of them. We *CANNOT* ship with 'J' as a default : for malloc. We'll never SHIP with J as default. It is there only for -current to catch bugs. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200007162312.RAA56337>