Date: Sat, 26 Jul 2003 02:16:51 -0700 From: Alfred Perlstein <bright@mu.org> To: Poul-Henning Kamp <phk@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/coda coda_fbsd.c coda_vnops.c src/sys/compat/linux linux_misc.c src/sys/dev/raidframe rf_freebsdkintf.c src/sys/fs/hpfs hpfs_vfsops.c src/sys/fs/msdosfs msdosfs_vfsops.c src/sys/fs/ntfs ntfs_vfsops.c src/sys/fs/nwfs ... Message-ID: <20030726091651.GB42924@elvis.mu.org> In-Reply-To: <200307260732.h6Q7WNqX008568@repoman.freebsd.org> References: <200307260732.h6Q7WNqX008568@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Poul-Henning Kamp <phk@FreeBSD.org> [030726 00:32] wrote: > phk 2003/07/26 00:32:23 PDT > > FreeBSD src repository > > Modified files: > sys/coda coda_fbsd.c coda_vnops.c > sys/compat/linux linux_misc.c > sys/dev/raidframe rf_freebsdkintf.c > Log: > Add a "int fd" argument to VOP_OPEN() which in the future will > contain the filedescriptor number on opens from userland. > > The index is used rather than a "struct file *" since it conveys a bit > more information, which may be useful to in particular fdescfs and /dev/fd/* > > For now pass -1 all over the place. This seems like a mistake, it forces one to have a struct filedesc instead of merely faking up a struct file. What if one wants to have a cookie without a filedesc? Am I mistaken? If there was a discussion on this you might want to float a "Discussed on: <listname>" in the log messages to shut me up. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.'
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030726091651.GB42924>