Date: Wed, 11 Sep 2024 21:53:20 -0400 From: "Jason E. Hale" <jhale@freebsd.org> To: Daniel Engberg <daniel.engberg.lists@pyret.net> Cc: "Jason E. Hale" <jhale@freebsd.org>, Po-Chuan Hsieh <sunpoet@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 6b2b6fc90d27 - main - www/nghttp2: Update to 1.63.0 Message-ID: <CAJE75NFRM-LwWnU2k=Wj35nXPTZxquoeEAMMM5a6pWL84beeog@mail.gmail.com> In-Reply-To: <3abbf023b2b18eeaacb34d7b1616b419@mail.infomaniak.com> References: <202409081842.488IgkEZ034994@gitrepo.freebsd.org> <6394ddba10e762464a9caeb391d10f36@mail.infomaniak.com> <CAJE75NFOoqu7dJxRubj7vxW2fZe=w=Z-5H0NrTR8UMHuEnGU8g@mail.gmail.com> <3abbf023b2b18eeaacb34d7b1616b419@mail.infomaniak.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 11, 2024 at 3:06=E2=80=AFPM Daniel Engberg <daniel.engberg.lists@pyret.net> wrote: > > On 2024-09-09T11:34:49.000+02:00, Jason E. Hale <jhale@freebsd.org> wrote= : > > On Sun, Sep 8, 2024 at 8:27=E2=80=AFPM Daniel Engberg > <daniel.engberg.lists@pyret.net> wrote: > > > On 2024-09-08T20:42:46.000+02:00, Po-Chuan Hsieh <sunpoet@FreeBSD.org> w= rote: > > > The branch main has been updated by sunpoet: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D6b2b6fc90d270c590a53a6c= 84ca1df897bf95e7c > > commit 6b2b6fc90d270c590a53a6c84ca1df897bf95e7c > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > AuthorDate: 2024-09-08 18:17:14 +0000 > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > CommitDate: 2024-09-08 18:37:04 +0000 > > www/nghttp2: Update to 1.63.0 > > > > > Hi, > > Both USES=3D compiler:c++20-lang and USE_CXXSTD=3D c++20 can be removed = as no c++ code is compiled. > > Best regards, > Daniel > > > All of the .cc files in ${WRKSRC}/src beg to differ. > > - Jason > > Hi, > > They're not compiled for the library at least according to the build log(= s). :-) > > CMake build: > https://pdr2.bofh.network/data/141-diizzy/2024-09-11_14h00m21s/logs/libng= http2-1.63.0.log > > Autotools: > https://pdr2.bofh.network/data/141-diizzy/2024-09-11_14h03m47s/logs/libng= http2-1.63.0.log > > Best regards, > Daniel True, but this commit wasn't for the library, so in that context, your critique seemed strange to me. - Jason
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJE75NFRM-LwWnU2k=Wj35nXPTZxquoeEAMMM5a6pWL84beeog>