Date: Fri, 25 Jun 2004 13:04:49 +0000 (UTC) From: Maxim Sobolev <sobomax@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sbin/gbde gbde.c Message-ID: <200406251304.i5PD4nYH020063@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
sobomax 2004-06-25 13:04:49 UTC
FreeBSD src repository
Modified files:
sbin/gbde gbde.c
Log:
o Fix semantics of comparison function for qsort(3). According to qsort(3)
manpage:
The comparison function must return an integer less than, equal to, or
greater than zero if the first argument is considered to be respectively
less than, equal to, or greater than the second.
Therefore, simply returning "arg1 > arg2" is incorrect. Actually it works
but for the number of items to be sorted less than 7 due to special case
handling in qsort(3);
o add missing '\n' to one of usage() calls.
Approved by: phk
Revision Changes Path
1.23 +6 -2 src/sbin/gbde/gbde.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406251304.i5PD4nYH020063>
