Date: Fri, 6 Apr 2007 18:27:11 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Andrey Chernov <ache@freebsd.org>, Bruce Evans <bde@zeta.org.au>, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include stdio.h src/lib/libc/sys lseek.2 pathconf.2 src/sys/kern vfs_syscalls.c src/sys/sys filio.h unistd.h Message-ID: <20070406162711.GD3519@garage.freebsd.pl> In-Reply-To: <20070406131127.GA91320@nagual.pp.ru> References: <200704052110.l35LAsXH013966@repoman.freebsd.org> <20070406115326.A43678@delplex.bde.org> <20070406053934.GA84722@nagual.pp.ru> <20070406103519.GA1251@garage.freebsd.pl> <20070406131127.GA91320@nagual.pp.ru>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Fri, Apr 06, 2007 at 05:11:28PM +0400, Andrey Chernov wrote: > On Fri, Apr 06, 2007 at 12:35:19PM +0200, Pawel Jakub Dawidek wrote: > > > > These are just namespace pollution in stdio.h. stdio (fseek()) doesn't > > > > support them, and the hack of declaring lseek() in stdio.h should not > > > > be extended to new interfaces. If stdio ever supports them, then they > > > > would need to be declared under a visibility ifdef (not #ifdef self). > > > > > > I agree. They must be implemented in fseek.c code first before adding them > > > to stdio.h and ifdefed with proper *_VISIBLE tags in all places. > > > Perhaps new __CDDL_VISIBLE tag required for it. > > > > This is not CDDL licensed. I'm planning to implement support for > > SEEK_DATA and SEEK_HOLE for UFS. > > This is not matter of license at all but matter of standards conformance. > > Feel free to invent any other __*_VISIBLE tag to exclude this addition > from namespace for programs which may define their own SEEK_DATA etc > which is allowed f.e. in POSIX namespace. Look like other __*_VISIBLE tags > are implemented and what they does. Default is turn all on. Ok, can someone help me with this? > In any case adding them to stdio.h is premature action - I not see yet > corresponding fseek() code. I'm looking at removing it from stdio.h. -- Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGFnTfForvXbEpPzQRAvT6AJ0YLvTnTsEPlmk61Qp9GSLwWtxFigCfW2eh +EmUysQuiJriFOVHE5q/KvI= =szmJ -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070406162711.GD3519>