Date: Fri, 6 Apr 2007 18:27:11 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Andrey Chernov <ache@freebsd.org>, Bruce Evans <bde@zeta.org.au>, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include stdio.h src/lib/libc/sys lseek.2 pathconf.2 src/sys/kern vfs_syscalls.c src/sys/sys filio.h unistd.h Message-ID: <20070406162711.GD3519@garage.freebsd.pl> In-Reply-To: <20070406131127.GA91320@nagual.pp.ru> References: <200704052110.l35LAsXH013966@repoman.freebsd.org> <20070406115326.A43678@delplex.bde.org> <20070406053934.GA84722@nagual.pp.ru> <20070406103519.GA1251@garage.freebsd.pl> <20070406131127.GA91320@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--OaZoDhBhXzo6bW1J Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 06, 2007 at 05:11:28PM +0400, Andrey Chernov wrote: > On Fri, Apr 06, 2007 at 12:35:19PM +0200, Pawel Jakub Dawidek wrote: > > > > These are just namespace pollution in stdio.h. stdio (fseek()) doe= sn't > > > > support them, and the hack of declaring lseek() in stdio.h should n= ot > > > > be extended to new interfaces. If stdio ever supports them, then t= hey > > > > would need to be declared under a visibility ifdef (not #ifdef self= ). > > >=20 > > > I agree. They must be implemented in fseek.c code first before adding= them=20 > > > to stdio.h and ifdefed with proper *_VISIBLE tags in all places. > > > Perhaps new __CDDL_VISIBLE tag required for it. > >=20 > > This is not CDDL licensed. I'm planning to implement support for > > SEEK_DATA and SEEK_HOLE for UFS. >=20 > This is not matter of license at all but matter of standards conformance. >=20 > Feel free to invent any other __*_VISIBLE tag to exclude this addition=20 > from namespace for programs which may define their own SEEK_DATA etc=20 > which is allowed f.e. in POSIX namespace. Look like other __*_VISIBLE tag= s=20 > are implemented and what they does. Default is turn all on. Ok, can someone help me with this? > In any case adding them to stdio.h is premature action - I not see yet > corresponding fseek() code. I'm looking at removing it from stdio.h. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --OaZoDhBhXzo6bW1J Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGFnTfForvXbEpPzQRAvT6AJ0YLvTnTsEPlmk61Qp9GSLwWtxFigCfW2eh +EmUysQuiJriFOVHE5q/KvI= =szmJ -----END PGP SIGNATURE----- --OaZoDhBhXzo6bW1J--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070406162711.GD3519>