Date: Sun, 14 Feb 2016 16:39:32 +0100 From: Hans Petter Selasky <hps@selasky.org> To: Adrian Chadd <adrian.chadd@gmail.com>, Andriy Voskoboinyk <s3erios@gmail.com> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r295607 - head/sys/dev/usb/wlan Message-ID: <56C09FB4.4000201@selasky.org> In-Reply-To: <CAJ-Vmo=9cCtdY5_a_mQVm5h5an7F=H75uw7LYu9uK3UEA5n0Vg@mail.gmail.com> References: <201602140716.u1E7Gaot040504@repo.freebsd.org> <CAJ-Vmo=9cCtdY5_a_mQVm5h5an7F=H75uw7LYu9uK3UEA5n0Vg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 02/14/16 16:23, Adrian Chadd wrote:
> uhm, why'd you not just file a separate pr for this?
>
> 8 keys limits how many stations it can support in hostap mode :( I'd
> rather the bitmap management code gets fixed.
>
Hi,
From what I can see 8 keys is the maximum due to the following shift:
/* Set cipher mode. */
if (rum_modbits(sc, rvp_id < 2 ? RT2573_SEC_CSR1 : RT2573_SEC_CSR5,
mode << (rvp_id % 2 + k->wk_keyix) * RT2573_SKEY_MAX,
RT2573_MODE_MASK << (rvp_id % 2 + k->wk_keyix) *
RT2573_SKEY_MAX)
!= 0)
goto print_err;
It is only about bitmanagement, but about where to actually write those
bits. Feel free to fix it.
--HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56C09FB4.4000201>