Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 21 Jul 2022 17:06:08 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 265005] asmc(4): Add MacBookPro6,2 support
Message-ID:  <bug-265005-227-4KeynDoezu@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-265005-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-265005-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265005

--- Comment #7 from Mark Johnston <markj@FreeBSD.org> ---
(In reply to ed crowe from comment #5)
Thanks!

With respect to interrupts, what happens in asmc(4) is that an interrupt
triggers a call to asmc_sms_intrfast(), which determines the interrupt type,
latches it in sc->sc_sms_intrtype, and potentially prints a message.  Then,=
 it
schedules a thread to deliver the devd notification, by calling
taskqueue_enqueue().  That causes asmc_sms_task() to be called.

So, the question is whether we do in fact want to hide these interrupts from
devd.  Per comment 4 it seems like the interrupts aren't spurious, i.e., the
driver is behaving more or less as intended.  So I think the real question =
is
whether the light sensor interrupt is generating "too many" notifications: =
when
running top(1), do you see devd consuming a significant amount of CPU time?=
  If
not, then I wouldn't worry much about it and can simply commit the latest
patch.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-265005-227-4KeynDoezu>