Date: Tue, 5 Jun 2018 09:45:57 -0500 From: Mahmoud Al-Qudsi <mqudsi@neosmart.net> To: Bruce Evans <brde@optusnet.com.au> Cc: bugs@freebsd.org Subject: Re: [Bug 228755] libvgl under syscons causes system reboot (via SDL 1.2) Message-ID: <CACcTrKc%2BL568Hxn3BHgWU0JBSTE%2BCs01EmWRz=Fjft-CJxJ8fg@mail.gmail.com> In-Reply-To: <20180605175705.Q2604@besplex.bde.org> References: <bug-228755-227@https.bugs.freebsd.org/bugzilla/> <20180605175705.Q2604@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 5, 2018 at 4:00 AM, Bruce Evans <brde@optusnet.com.au> wrote: > After fixing libvgl to use MAP_SHARED, libvgl and the demo work much the > same as in FreeBSD-5. Modes up to 1280x1024x8 work in both. Fancier > modes fail in both. The only interesting difference is that mmap() fails > for VGA mode 257 in -current both works in FreeBSD-5. The same (FreeBSD-5) > libvgl and demo program apparently calculates a too-large frame buffer size > in -current only, and mmapping this fails. mmap() also fails for > 1920x1080x8. Getting this size wrong in the driver is more likely to > cause a reboot than failing. Yes, I ran into that bug when attempting to pin down the underlying problem in libvgl directly instead of using SDL; when I manually called VGLInit with a mode that didn't directly error out (with a return code greater than -7), the memory allocation would fail and VGLInit() would return -7. (The buffer size should be printed with LIBVGL_DEBUG _before_ the attempted memory allocation currently on line 258 of libvgl/main.c, imho). But, as you say, that doesn't cause the system to reboot, obviously. Mahmoud Al-Qudsi NeoSmart Technologies
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACcTrKc%2BL568Hxn3BHgWU0JBSTE%2BCs01EmWRz=Fjft-CJxJ8fg>