Date: Thu, 10 Sep 2015 03:37:23 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Jason Unovitch <junovitch@FreeBSD.org> Cc: Chris Hutchinson <portmaster@bsdforge.com>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r396547 - in head/textproc: . smi Message-ID: <k2rz-5a24-wny@FreeBSD.org> In-Reply-To: <201509100045.t8A0jQFW087140@repo.freebsd.org> (Jason Unovitch's message of "Thu, 10 Sep 2015 00:45:26 %2B0000 (UTC)") References: <201509100045.t8A0jQFW087140@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain
Jason Unovitch <junovitch@FreeBSD.org> writes:
> +post-patch:
> + ${REINPLACE_CMD} -e 's|^CC = .*|CC = ${CC}|' \
CC is defined by default to a sane value in both GNU and BSD make.
One can do '/^CC/d' but see below for better way.
> + -e 's|^PREFIX = .*|PREFlX = ${PREFIX}|' \
^^^
Typo: l .vs I. It still works because PREFIX is also passed via MAKE_ENV.
> + -e 's|^MANPREFIX = .*|MANPREFIX = ${MANPREFIX}|' \
> + ${WRKSRC}/config.mk
If possible try to avoid patching makefiles if overriding a few
variables is enough. For one, your entire post-patch can be:
MAKE_ARGS= CC="${CC}" PREFIX="${PREFIX}" MANPREFIX="${MANPREFIX}"
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQF8BAEBCgBmBQJV8N7TXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF
NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bD/AH/R7YSyommIay+lFB0e6wSmlI
w6ijRpTNfhGj7tHMpAbm4RxvM00NQvD7CrkZkObsz1tN61wzVhaef7/CK4/fsPuq
dQJTIsOG7TUQDIrfNHMU7coky/wKM4TDFeA/UGzsz3G7CeKG2vCZel9gDNWbhk7e
uAS2t4CJnN3cQ3dkuIGiH6GhAh7uke2Km+WtfgeLqkIoHgWVXA7q4bebFijFS5R1
OSZNoQFODXKY0D7/BxIlL8olWox+HQ+5Hs1GO56ztdu67W3sBPmobWH30QsSv1O5
/dv6hDqi8o8C/0XgvvZl1+QQZXRnjOsUU9d4N0WQ+OzNSSYXok8PLAAAzepgf0g=
=Xj2z
-----END PGP SIGNATURE-----
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?k2rz-5a24-wny>