Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 28 May 2018 20:47:40 +0000 (UTC)
From:      Alan Somers <asomers@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r334296 - head/sys/security/audit
Message-ID:  <201805282047.w4SKlesF026756@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: asomers
Date: Mon May 28 20:47:39 2018
New Revision: 334296
URL: https://svnweb.freebsd.org/changeset/base/334296

Log:
  Fix "Bad tailq" panic when auditing auditon(A_SETCLASS, ...)
  
  Due to an oversight in r195280, auditon(A_SETCLASS, ...) would cause a tailq
  element to get added to the tailq twice, resulting in a circular tailq. This
  panics when INVARIANTS are on.
  
  MFC after:	2 weeks
  Differential Revision:	https://reviews.freebsd.org/D15381

Modified:
  head/sys/security/audit/audit_bsm.c

Modified: head/sys/security/audit/audit_bsm.c
==============================================================================
--- head/sys/security/audit/audit_bsm.c	Mon May 28 20:29:03 2018	(r334295)
+++ head/sys/security/audit/audit_bsm.c	Mon May 28 20:47:39 2018	(r334296)
@@ -427,7 +427,6 @@ audit_sys_auditon(struct audit_record *ar, struct au_r
 		break;
 
 	case A_SETCLASS:
-		kau_write(rec, tok);
 		tok = au_to_arg32(2, "setclass:ec_event",
 		    ar->ar_arg_auditon.au_evclass.ec_number);
 		kau_write(rec, tok);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201805282047.w4SKlesF026756>