Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 15 Jun 2007 10:41:42 +0700
From:      Max Khon <fjoe@samodelkin.net>
To:        Alejandro Pulver <alepulver@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, Alexey Dokuchaev <danfe@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/sysutils/fusefs-ntfs Makefile distinfo ports/sysutils/fusefs-ntfs/files extra-patch-ublio patch-libntfs-3g-device_io.c patch-libntfs-3g__device.c patch-libntfs-3g__unix_io.c patch-src-ntfs-3g.c pkg-message.in unix_io_raw.c
Message-ID:  <20070615034141.GA27512@samodelkin.net>
In-Reply-To: <20070613154224.66bcb38d@deimos.mars.bsd>
References:  <200706070401.l5741Z6c048367@repoman.freebsd.org> <20070612190234.GA52970@samodelkin.net> <20070613110522.GA62935@FreeBSD.org> <20070613154224.66bcb38d@deimos.mars.bsd>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi!

On Wed, Jun 13, 2007 at 03:42:24PM -0300, Alejandro Pulver wrote:

> > > > alepulver    2007-06-07 04:01:33 UTC
> > > > 
> > > >   FreeBSD ports repository
> > > > 
> > > >   Modified files:
> > > >     sysutils/fusefs-ntfs Makefile distinfo 
> > > >   Added files:
> > > >     sysutils/fusefs-ntfs/files extra-patch-ublio 
> > > >                                patch-libntfs-3g__device.c 
> > > >                                patch-libntfs-3g__unix_io.c 
> > > >                                pkg-message.in 
> > > >   Removed files:
> > > >     sysutils/fusefs-ntfs/files patch-libntfs-3g-device_io.c 
> > > >                                patch-src-ntfs-3g.c unix_io_raw.c 
> > > 
> > > Why did you rename patch files? Please back this out.
> > 
> > This is not the first time I've seen people rename existing patch files,
> > while IIRC current policy tells us to abstain from doing so.  Only new
> > files are subject to new (more strict) naming rules.  Let's follow the
> > guidelines.
> 
> I think there has been a misunderstanding here: the removed patch file
> is for device_io.c, and the added one for device.c which are different
> files with different sets of changes.

Indeed. Anyway, I'd prefer that you keep existing naming rules next time.

/fjoe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070615034141.GA27512>