Date: Fri, 30 Apr 1999 15:19:03 -0700 (PDT) From: cpeterso@cs.washington.edu To: freebsd-gnats-submit@freebsd.org Subject: kern/11410: code typo in ad1848.c: the != operator has higher precedence than the & operator. Message-ID: <19990430221903.AB79814EB7@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 11410
>Category: kern
>Synopsis: code typo in ad1848.c: the != operator has higher precedence than the & operator.
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Apr 30 15:20:01 PDT 1999
>Closed-Date:
>Last-Modified:
>Originator: Christopher Peterson
>Release: FreeBSD 3.1-RELEASE i386
>Organization:
>Environment:
>Description:
i386/isa/snd/ad1848.c (line 2039): & XXX == ; 8:
if (inb(ad1816_int(d)) & AD1816_INTRPI != 0)
The != operator has higher precedence than the & operator. Therefore
the above line is actually compiled as:
if (inb(ad1816_int(d)) & (AD1816_INTRPI != 0) )
but the author probably meant:
if ( (inb(ad1816_int(d)) & AD1816_INTRPI) != 0)
>How-To-Repeat:
>Fix:
if ( (inb(ad1816_int(d)) & AD1816_INTRPI) != 0)
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990430221903.AB79814EB7>