Date: Sat, 21 Sep 2024 19:03:18 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: a52b30ff98cd - main - sys_pipe: consistently use cr_ruidinfo for accounting of pipebuf Message-ID: <86y13lx7l5.fsf@ltc.des.dev> In-Reply-To: <Zu7A8bFd_cDIUKTD@kib.kiev.ua> (Konstantin Belousov's message of "Sat, 21 Sep 2024 15:49:53 %2B0300") References: <202409202109.48KL9RZ1078677@gitrepo.freebsd.org> <867cb5z2c3.fsf@ltc.des.dev> <Zu7A8bFd_cDIUKTD@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Konstantin Belousov <kostikbel@gmail.com> writes: > Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org> writes: > > Konstantin Belousov <kib@FreeBSD.org> writes: > > > commit a52b30ff98cdab82af140285fa7fcdf1036fef27 > > > > > > sys_pipe: consistently use cr_ruidinfo for accounting of pipebuf > > >=20=20=20=20=20 > > > Tested by: yasu > > > Sponsored by: The FreeBSD Foundation >> > MFC after: 1 week > > This appears to be the opposite of the patch which you posted on > > -current and which yasu@ tested [...] > Before committing anything, I did a self-review and remembered that I > have did a lot of considerations when implementing swap accounting and > decided that ruid is the right target for charge. > > Besides stating the obvious fact above, what do you expect me to answer/ > react to your mail? My point is that the commit message claims the patch was tested by yasu@ when in fact it wasn't. If you're convinced that this is the correct solution then that's fine, and it does appear to work, but don't claim that it's been tested by others when it hasn't. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86y13lx7l5.fsf>