Date: Sun, 14 Dec 2008 14:22:10 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: hselasky@freebsd.org Cc: perforce@freebsd.org Subject: Re: PERFORCE change 154172 for review Message-ID: <20081214.142210.1102529432.imp@bsdimp.com> In-Reply-To: <200812061000.mB6A0YwA051708@repoman.freebsd.org> References: <200812061000.mB6A0YwA051708@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200812061000.mB6A0YwA051708@repoman.freebsd.org>
Hans Petter Selasky <hselasky@freebsd.org> writes:
: ==== //depot/projects/usb/src/sys/dev/usb/usbdevs#27 (text+ko) ====
:
: @@ -811,6 +811,7 @@
: product ALCOR UMCR_9361 0x9361 USB Multimedia Card Reader
: product ALCOR SM_KBD 0x9410 MicroConnectors/StrongMan Keyboard
: product ALCOR NEC_KBD_HUB 0x9472 NEC Kbd Hub
: +product ALCOR TRANSCEND 0x6387 Transcend JetFlash Drive
This should be sorted by device id number. Also, it is
product<space>, not product<tab>
Warner
: /* Altec Lansing products */
: product ALTEC ADA70 0x0070 ADA70 Speakers
:
: ==== //depot/projects/usb/src/sys/dev/usb2/include/usb2_devid.h#13 (text+ko) ====
:
: @@ -818,6 +818,7 @@
: #define USB_PRODUCT_ALCOR_UMCR_9361 0x9361 /* USB Multimedia Card Reader */
: #define USB_PRODUCT_ALCOR_SM_KBD 0x9410 /* MicroConnectors/StrongMan Keyboard */
: #define USB_PRODUCT_ALCOR_NEC_KBD_HUB 0x9472 /* NEC Kbd Hub */
: +#define USB_PRODUCT_ALCOR_TRANSCEND 0x6387 /* Transcend JetFlash Drive */
:
: /* Altec Lansing products */
: #define USB_PRODUCT_ALTEC_ADA70 0x0070 /* ADA70 Speakers */
:
: ==== //depot/projects/usb/src/sys/dev/usb2/include/usb2_devtable.h#13 (text+ko) ====
:
: @@ -653,6 +653,12 @@
: "NEC Kbd Hub",
: },
: {
: + USB_VENDOR_ALCOR, USB_PRODUCT_ALCOR_TRANSCEND,
: + 0,
: + "Alcor Micro",
: + "Transcend JetFlash Drive",
: + },
: + {
: USB_VENDOR_ALTEC, USB_PRODUCT_ALTEC_ADA70,
: 0,
: "Altec Lansing",
:
: ==== //depot/projects/usb/src/sys/dev/usb2/storage/umass2.c#17 (text+ko) ====
:
: @@ -400,6 +400,10 @@
: UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
: NO_GETMAXLUN
: },
: + {USB_VENDOR_ALCOR, USB_PRODUCT_ALCOR_TRANSCEND, RID_WILDCARD,
: + UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
: + NO_GETMAXLUN
: + },
: {USB_VENDOR_ASAHIOPTICAL, USB_PRODUCT_ASAHIOPTICAL_OPTIO230, RID_WILDCARD,
: UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
: NO_INQUIRY
: @@ -636,10 +640,10 @@
: UMASS_PROTO_SCSI,
: NO_GETMAXLUN
: },
: - { USB_VENDOR_ONSPEC, USB_PRODUCT_ONSPEC_SDS_HOTFIND_D, RID_WILDCARD,
: - UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
: - NO_GETMAXLUN | NO_SYNCHRONIZE_CACHE
: - },
: + {USB_VENDOR_ONSPEC, USB_PRODUCT_ONSPEC_SDS_HOTFIND_D, RID_WILDCARD,
: + UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
: + NO_GETMAXLUN | NO_SYNCHRONIZE_CACHE
: + },
: {USB_VENDOR_ONSPEC, USB_PRODUCT_ONSPEC_CFMS_RW, RID_WILDCARD,
: UMASS_PROTO_SCSI,
: NO_QUIRKS
:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081214.142210.1102529432.imp>