Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 17 Aug 2023 18:32:43 GMT
From:      John Baldwin <jhb@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 18974bd616ae - main - bhyve: Store the FreeBSD OUI in little-endian in the controller data
Message-ID:  <202308171832.37HIWhkg045830@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by jhb:

URL: https://cgit.FreeBSD.org/src/commit/?id=18974bd616ae141c8721b8b01eb634670f5ccd56

commit 18974bd616ae141c8721b8b01eb634670f5ccd56
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2023-08-17 18:30:50 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2023-08-17 18:32:32 +0000

    bhyve: Store the FreeBSD OUI in little-endian in the controller data
    
    Section 7.10.3 of the NVME 1.4b specification states that the IEEE OUI
    in the identify controller structure is stored in little-endian format
    (unlike the embedded OUI in EUI64 identifiers).
    
    Reviewed by:    corvink, chuck, imp
    Sponsored by:   Chelsio Communications
    Differential Revision:  https://reviews.freebsd.org/D41487
---
 usr.sbin/bhyve/pci_nvme.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/usr.sbin/bhyve/pci_nvme.c b/usr.sbin/bhyve/pci_nvme.c
index 5bdf4c454a23..d1b15d6f3a3c 100644
--- a/usr.sbin/bhyve/pci_nvme.c
+++ b/usr.sbin/bhyve/pci_nvme.c
@@ -525,9 +525,9 @@ pci_nvme_init_ctrldata(struct pci_nvme_softc *sc)
 	cd->rab   = 4;
 
 	/* FreeBSD OUI */
-	cd->ieee[0] = 0x58;
+	cd->ieee[0] = 0xfc;
 	cd->ieee[1] = 0x9c;
-	cd->ieee[2] = 0xfc;
+	cd->ieee[2] = 0x58;
 
 	cd->mic = 0;
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202308171832.37HIWhkg045830>