Date: Thu, 25 Jun 2009 12:42:52 +0200 From: Rafal Jaworowski <raj@semihalf.com> To: Alexander Motin <mav@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, =?ISO-8859-2?Q?Piotr_Zi=EAcik?= <kosmo@semihalf.com> Subject: Re: svn commit: r194844 - in head/sys: conf dev/ata Message-ID: <BAEDE02F-7A07-4AE7-8311-5675401B5901@semihalf.com> In-Reply-To: <4A434F2C.1020005@FreeBSD.org> References: <200906241538.n5OFcHwp018860@svn.freebsd.org> <4A434F2C.1020005@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2009-06-25, at 12:19, Alexander Motin wrote: > Rafal Jaworowski wrote: >> Modified: head/sys/conf/files >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- head/sys/conf/files Wed Jun 24 15:33:33 2009 (r194843) >> +++ head/sys/conf/files Wed Jun 24 15:38:17 2009 (r194844) >> @@ -491,12 +491,12 @@ dev/ata/ata_if.m optional ata | atacore >> dev/ata/ata-all.c optional ata | atacore >> dev/ata/ata-lowlevel.c optional ata | atacore >> dev/ata/ata-queue.c optional ata | atacore >> +dev/ata/ata-dma.c optional ata | atadma >> +dev/ata/ata-sata.c optional ata | atasata > > What is atadma and atasata here, kernel options? What for are they > needed? You will not be able to build most of drivers without them, > while enabling them for others will not give you any benefit, just > bigger code size. I think dependency must be reviewed there. This was supposed to follow the fine grained kernel options route for various ata subsystems. Both ata-dma.c and ata-sata.c seem orthogonal to the rest of the ata framework (think ata controller without DMA, which is often seen in embedded). They could also be made mandatory under atacore, I have no problem with this approach too. Rafal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BAEDE02F-7A07-4AE7-8311-5675401B5901>