Date: Wed, 19 Jun 2013 17:39:12 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Nikos Vassiliadis <nvass@gmx.com> Cc: Mikolaj Golub <trociny@FreeBSD.org>, freebsd-pf@freebsd.org Subject: Re: de-virtualize pf sysctls Message-ID: <20130619133912.GD1214@glebius.int.ru> In-Reply-To: <51BD9DF3.1080808@gmx.com> References: <51B33B8B.9050006@gmx.com> <51B344B8.9090109@gmx.com> <20130612185150.GA6553@gmail.com> <51BD9DF3.1080808@gmx.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jun 16, 2013 at 01:13:55PM +0200, Nikos Vassiliadis wrote: N> >>> Please review this patch. These two variables are RO-tunables and N> >>> cannot be changed at runtime. As such, it is not useful to N> >>> virtualize them. N> > N> > This looks correct to me. Also, it looks like V_pf_hashmask and N> > V_pf_srchashmask can be de-virtualized then. N> N> Yes, taken care of on this version. I am not sure if I placed N> properly pf_hashmask and pf_srchashmask in pfvar.h. N> N> Please review, thanks. Thanks, Nikos. I committed the patch to the branch projects/pf/head. Can you please check out this branch and generate further pf+vimage related diffs against it? Once we finish and stabilize it, I will merge the branch to head. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130619133912.GD1214>