Date: Fri, 09 Jul 2021 08:27:46 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 257067] panic: Assertion in_epoch(net_epoch_preempt) failed at /usr/src/sys/net/if_vlan.c:1185 Message-ID: <bug-257067-227-6zWFjx5OBy@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-257067-227@https.bugs.freebsd.org/bugzilla/> References: <bug-257067-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D257067 Aleksandr Fedorov <afedorov@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |afedorov@FreeBSD.org, | |donner@FreeBSD.org, | |glebius@FreeBSD.org, | |markj@FreeBSD.org --- Comment #1 from Aleksandr Fedorov <afedorov@FreeBSD.org> --- I think this is a bug in the ng_ppoe(4) code. Disconnecting hooks are called outside of NET_EPOCH, but ng_pppoe_disconnect() calls NG_SEND_DATA_ONLY() w= hich should be called in NET_EPOCH. Please try the following patch: diff --git a/sys/netgraph/ng_pppoe.c b/sys/netgraph/ng_pppoe.c index 295a136cc55..e07f77b9d54 100644 --- a/sys/netgraph/ng_pppoe.c +++ b/sys/netgraph/ng_pppoe.c @@ -2037,6 +2037,7 @@ ng_pppoe_disconnect(hook_p hook) log(LOG_NOTICE, "ng_pppoe[%x]: session out = of " "mbufs\n", node->nd_ID); else { + struct epoch_tracker et; struct pppoe_full_hdr *wh; struct pppoe_tag *tag; int msglen =3D strlen(SIGNOFF); @@ -2067,8 +2068,11 @@ ng_pppoe_disconnect(hook_p hook) m->m_pkthdr.len =3D m->m_len =3D sizeof(*wh= ) + sizeof(*tag) + msglen; wh->ph.length =3D htons(sizeof(*tag) + msgl= en); + + NET_EPOCH_ENTER(et); NG_SEND_DATA_ONLY(error, privp->ethernet_hook, m); + NET_EPOCH_EXIT(et); } } if (sp->state =3D=3D PPPOE_LISTENING) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-257067-227-6zWFjx5OBy>