Date: Mon, 21 Aug 2017 21:56:17 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-dtrace@FreeBSD.org Subject: [Bug 219451] [dtrace] Certain llquantize() parameters trigger assertion Message-ID: <bug-219451-32976-pJXmOnpzLY@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-219451-32976@https.bugs.freebsd.org/bugzilla/> References: <bug-219451-32976@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D219451 --- Comment #4 from commit-hook@freebsd.org --- A commit references this bug: Author: markj Date: Mon Aug 21 21:56:03 UTC 2017 New revision: 322773 URL: https://svnweb.freebsd.org/changeset/base/322773 Log: Fix an off-by-two in the llquantize() action parameter validation. The aggregation created by llquantize() partitions values into buckets; t= he lower bound of the bucket containing the largest values is b^{m+1}, where b and m are the second and fourth parameters to the action, respectively. Bucket bounds are stored in a 64-bit integer, and so the llquantize() validation checks need to verify that b^{m+1} fits in 64 bits. However, it was only verifying that b^{m-1} fits in 64 bits, so certain parameter combinations could trigger assertion failures in libdtrace. PR: 219451 MFC after: 1 week Changes: head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_cc.c --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-219451-32976-pJXmOnpzLY>