Date: Tue, 22 Feb 2022 18:20:08 +0900 From: Tomoaki AOKI <junchoon@dec.sakura.ne.jp> To: Tatsuki Makino <tatsuki_makino@hotmail.com> Cc: Stephen Montgomery-Smith <montgomerysmithstephen@gmail.com>, Craig Leres <leres@freebsd.org>, "Alex V. Petrov" <alexvpetrov@gmail.com>, chromium@FreeBSD.org, ports@FreeBSD.org Subject: Re: FreeBSD Port: chromium-98.0.4758.102 Error build on 13-stable Message-ID: <20220222182008.5d231b8bb3f812691d6f8343@dec.sakura.ne.jp> In-Reply-To: <PSAPR03MB5639AA04842C4469E9588199FA3B9@PSAPR03MB5639.apcprd03.prod.outlook.com> References: <f027f938-1b1d-e6c6-2ce4-dec7bc3a3e34@gmail.com> <e0be9b5a-28c9-60a1-74aa-86cc9001149b@freebsd.org> <240efd99-514a-3b21-85cf-361e0087aef2@FreeBSD.org> <20220222065318.29e395623073010db2e02961@dec.sakura.ne.jp> <PSAPR03MB5639AA04842C4469E9588199FA3B9@PSAPR03MB5639.apcprd03.prod.outlook.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 22 Feb 2022 12:44:16 +0900 Tatsuki Makino <tatsuki_makino@hotmail.com> wrote: > Hello. > > What are the files that exist in /usr/ports/www/chromium/files/patch-third__party_nasm_config_config-linux.h doing? > Isn't it like mempcpy exists but HAVE_MEMPCPY is not defined, so we see this and get an error? > > Regards. It patches the file controlling several options for building bundled nasm. IIUC, as I'm not a member of chromium team, patchset are modified to share with OpenBSD chromium team in conjunction with upgrading to 98.0.4758.102. With this change, FreeBSD-specific patch and corresponding portion of Makefike introduced by bug 257352 [1], then, modified again by Bug 258271 [2]. Fix is ongoing at [2], currently by [3]. The proposed patch [3] can be placed to www/chromium/files/ as is, and builds fine on stable/13, amd64 git c39ff2415cb9 for me. [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257352 [2] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258271 [3] https://bz-attachments.freebsd.org/attachment.cgi?id=231983 Some details: FreeBSD src main before git ee37f64cf875, stable/13 before git dba677d13b26 and all revisions of stable/12 don't have mempcpy() yet. Not sure but maybe OpenBSD, too. This is why HAVE_MEMPCPY part of {WRKSRC}/third_party/nasm/config/config-linux.h is patched to disable by the patch you mentioned and cause of this breakage on main and stable/13 including and after above-mentioned commit. I'm not familiar wit gn build system, but maybe proposed patch [3] toggles HAVE_MEMPCPY defined again (or something equivalent) for all revisions having mempcpy() defined in /usr/include/string.h. -- Tomoaki AOKI <junchoon@dec.sakura.ne.jp>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220222182008.5d231b8bb3f812691d6f8343>