Date: Mon, 23 Feb 2004 20:03:49 +0200 From: Alexander Motin <mav@alkar.net> To: Andre Oppermann <andre@freebsd.org> Cc: freebsd-ipfw@freebsd.org Subject: Re: Generating 'Fragment Needed but DF was Set' ICMP & Dummynet Message-ID: <403A4085.6070202@alkar.net> In-Reply-To: <403A323C.A8685981@freebsd.org> References: <c0soic$1njq$2@pandora.alkar.net.lucky.freebsd.net> <c1d9id$10qf$1@pandora.alkar.net> <403A323C.A8685981@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Andre Oppermann wrote: > Alexander Motin wrote: > >>Here are my patches for this problem for FreeBSD 4.8 and 5.2. >>Review them please. > > Doing a mcopy is pretty ugly... but ip_output() doesn't offer any way > of saying "don't flush packet but leave it for icmp error messages". > > So the better fix would be to teach that to ip_output() and change > the callers accordingly. Actually I'll have a patch to do that ready > in a couple of hours. Then I'll commit your patch w/o the packet > copying stuff. This was taken from ip_forward(). :) If you say that it can be reworked here then it can be reworked there too for increasing performance. -- Alexander Motin mav@alkar.net ISP "Alkar-Teleport"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?403A4085.6070202>