Date: Thu, 21 May 2026 23:51:43 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: Mark Millard <marklmi@yahoo.com> Cc: dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4dd97955e68d - main - libpkgconf: Fix paths Message-ID: <CAFDf7ULO08320gYxmeoqnvvXc4cxDqLsD5aXz-WrDVgcKms6kA@mail.gmail.com> In-Reply-To: <6f82ab2f-b5da-429f-84ed-4d5b7af5f5f0@yahoo.com> References: <69ee1653.34850.61462b24@gitrepo.freebsd.org> <24a05f73-84a3-480f-b797-e0688753810c@yahoo.com> <CAFDf7U%2Bz16qRxMWA%2B=iq_GapPp1T3gfTnibn5rp-cKSmWmMP4w@mail.gmail.com> <6f82ab2f-b5da-429f-84ed-4d5b7af5f5f0@yahoo.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Hello Mark, Sorry for bad reply... I did take a look a https://reviews.freebsd.org/D56404 and noticed that ivy@ participate on it and did open https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=295439 For what I see in PR is that uacme pkgconf problem is related to PREFIX set to pkg maybe related to pkgbase method when installing main or suing a custom PREFIX. Thanks, Mark Millard <marklmi@yahoo.com> escreveu (quinta, 21/05/2026 à(s) 21:21): > On 5/21/26 11:18, Nuno Teixeira wrote: > > Hello, > > > > This change doens't honour PREFIX when it is set to other path than > > default "/usr/local/" > > As I only had noted an unexpected year in a date when I read the > original and replied about that, replying to my message instead of > des@'s original message is a little odd. > > But, in response, I did post a question to the review of the original > https://reviews.freebsd.org/D56404 ("pkgconf: import into the base > system"), asking: > > "What is the relationship of this type of change to use of ${PREFIX} > when ports install themselves and it is not the /usr/local default > value? (There is also a linux compatibility related standard default for > PREFIX and folks can specify things like /opt .)" > > I referenced you and your message. > > > > > -CFLAGS+= -DPERSONALITY_PATH=\"/usr/share/pkgconfig/ > > personality.d:/etc/pkgconfig/personality.d:${LOCALBASE:U}/etc/pkgconfig/ > > personality.d\" > > -CFLAGS+= -DPKG_DEFAULT_PATH=\"${LOCALBASE:U}/libdata/pkgconfig:/ > > usr/libdata/pkgconfig:${LOCALBASE:U}/share/pkgconfig\" > > +CFLAGS+= -DPERSONALITY_PATH=\"/usr/share/pkgconfig/ > > personality.d:/etc/pkgconfig/personality.d:${LOCALBASE:U/usr/local}/etc/ > > pkgconfig/personality.d\" > > +CFLAGS+= -DPKG_DEFAULT_PATH=\"${LOCALBASE:U/usr/local}/libdata/ > > > pkgconfig:/usr/libdata/pkgconfig:${LOCALBASE:U/usr/local}/share/pkgconfig\" > > > > Please see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=295439 > > <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=295439>; > > > > Thanks, > > > > Mark Millard <marklmi@yahoo.com <mailto:marklmi@yahoo.com>> escreveu > > (domingo, 26/04/2026 à(s) 19:08): > > > > On 4/26/26 06:42, Dag-Erling Smørg rav wrote: > > > The branch main has been updated by des: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/? > > id=4dd97955e68df02b26d59e4e7c9a8167947a5164 <https:// > > cgit.FreeBSD.org/src/commit/? > > id=4dd97955e68df02b26d59e4e7c9a8167947a5164> > > > > > > commit 4dd97955e68df02b26d59e4e7c9a8167947a5164 > > > Author: Dag-Erling Smørgrav <des@FreeBSD.org> > > > AuthorDate: 2026-04-26 13:41:47 +0000 > > > Commit: Dag-Erling Smørgrav <des@FreeBSD.org> > > > CommitDate: 2026-04-26 13:41:47 +0000 > > > > > > libpkgconf: Fix paths > > > > > > ${LOCALBASE:U} evaluates to exactly the same thing as > > ${LOCALBASE}. > > > Presumably what was meant was ${LOCALBASE:U/usr/local}. > > > > > > Fixes: b8352da33f34 ("pkgconf: import into the base > > system") > > > Reviewed by: khorben > > > Differential Revision: https://reviews.freebsd.org/D56642 > > <https://reviews.freebsd.org/D56642>; > > > --- > > > lib/libpkgconf/Makefile | 4 ++-- > > > tools/build/depend-cleanup.sh | 4 ++++ > > > 2 files changed, 6 insertions(+), 2 deletions(-) > > > > > > diff --git a/lib/libpkgconf/Makefile b/lib/libpkgconf/Makefile > > > index fee7f275d9ff..3cfb2172a00e 100644 > > > --- a/lib/libpkgconf/Makefile > > > +++ b/lib/libpkgconf/Makefile > > > @@ -14,8 +14,8 @@ INCS= bsdstubs.h iter.h > > libpkgconf-api.h libpkgconf.h stdinc.h > > > > > > WARNS?= 3 > > > > > > -CFLAGS+= -DPERSONALITY_PATH=\"/usr/share/pkgconfig/ > > personality.d:/etc/pkgconfig/personality.d:${LOCALBASE:U}/etc/ > > pkgconfig/personality.d\" > > > -CFLAGS+= -DPKG_DEFAULT_PATH=\"${LOCALBASE:U}/libdata/ > > pkgconfig:/usr/libdata/pkgconfig:${LOCALBASE:U}/share/pkgconfig\" > > > +CFLAGS+= -DPERSONALITY_PATH=\"/usr/share/pkgconfig/ > > personality.d:/etc/pkgconfig/personality.d:${LOCALBASE:U/usr/local}/ > > etc/pkgconfig/personality.d\" > > > +CFLAGS+= -DPKG_DEFAULT_PATH=\"${LOCALBASE:U/usr/local}/ > > libdata/pkgconfig:/usr/libdata/pkgconfig:${LOCALBASE:U/usr/local}/ > > share/pkgconfig\" > > > CFLAGS+= -DSYSTEM_INCLUDEDIR=\"/usr/include\" > > > CFLAGS+= -DSYSTEM_LIBDIR=\"/usr/lib\" > > > CFLAGS+= -I${SRCTOP}/lib/libpkgconf -I${PKGCONFDIR} > > > diff --git a/tools/build/depend-cleanup.sh b/tools/build/depend- > > cleanup.sh > > > index e9c02d015368..c186c39a3448 100755 > > > --- a/tools/build/depend-cleanup.sh > > > +++ b/tools/build/depend-cleanup.sh > > > @@ -317,6 +317,10 @@ check_epoch_and_opts > > > # "$OBJTOP"/tests/sys/kqueue/libkqueue/* > > > #fi > > > > > > +# 20250426 # libpkgconfig contains incorrect paths > > > > 2025 above is a typo? > > > > > +clean_obj lib/libpkgconf personality c pkgconfig:/share > > > +clean_obj lib/libpkgconf pkg c pkgconfig:/share > > > + > > > # 20251219 # libkrb5profile is now internal > > > for libcompat in "" $ALL_libcompats; do > > > dirprfx=${libcompat:+obj-lib${libcompat}} > > > > > > > > > > > > -- > > === > > Mark Millard > > marklmi at yahoo.com <http://yahoo.com>; > > > > > > > > -- > > Nuno Teixeira > > FreeBSD UNIX: <eduardo@FreeBSD.org> Web: https://FreeBSD.org > > <https://FreeBSD.org>; > > > -- > === > Mark Millard > marklmi at yahoo.com > -- Nuno Teixeira FreeBSD UNIX: <eduardo@FreeBSD.org> Web: https://FreeBSD.org [-- Attachment #2 --] <div dir="ltr"><div><div><div><div>Hello Mark,<br><br></div>Sorry for bad reply...<br><br></div>I did take a look a <a href="https://reviews.freebsd.org/D56404">https://reviews.freebsd.org/D56404</a>; and noticed that ivy@<br>participate on it and did open <a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=295439">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=295439</a><br><br></div>For what I see in PR is that uacme pkgconf problem is related to PREFIX set to pkg maybe related to pkgbase method when installing main or suing a custom PREFIX.<br><br></div>Thanks,</div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">Mark Millard <<a href="mailto:marklmi@yahoo.com">marklmi@yahoo.com</a>> escreveu (quinta, 21/05/2026 à(s) 21:21):<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 5/21/26 11:18, Nuno Teixeira wrote:<br> > Hello,<br> > <br> > This change doens't honour PREFIX when it is set to other path than<br> > default "/usr/local/"<br> <br> As I only had noted an unexpected year in a date when I read the<br> original and replied about that, replying to my message instead of<br> des@'s original message is a little odd.<br> <br> But, in response, I did post a question to the review of the original<br> <a href="https://reviews.freebsd.org/D56404" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D56404</a>; ("pkgconf: import into the base<br> system"), asking:<br> <br> "What is the relationship of this type of change to use of ${PREFIX}<br> when ports install themselves and it is not the /usr/local default<br> value? (There is also a linux compatibility related standard default for<br> PREFIX and folks can specify things like /opt .)"<br> <br> I referenced you and your message.<br> <br> > <br> > -CFLAGS+= -DPERSONALITY_PATH=\"/usr/share/pkgconfig/<br> > personality.d:/etc/pkgconfig/personality.d:${LOCALBASE:U}/etc/pkgconfig/<br> > personality.d\"<br> > -CFLAGS+= -DPKG_DEFAULT_PATH=\"${LOCALBASE:U}/libdata/pkgconfig:/<br> > usr/libdata/pkgconfig:${LOCALBASE:U}/share/pkgconfig\"<br> > +CFLAGS+= -DPERSONALITY_PATH=\"/usr/share/pkgconfig/<br> > personality.d:/etc/pkgconfig/personality.d:${LOCALBASE:U/usr/local}/etc/<br> > pkgconfig/personality.d\"<br> > +CFLAGS+= -DPKG_DEFAULT_PATH=\"${LOCALBASE:U/usr/local}/libdata/<br> > pkgconfig:/usr/libdata/pkgconfig:${LOCALBASE:U/usr/local}/share/pkgconfig\"<br> > <br> > Please see <a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=295439" rel="noreferrer" target="_blank">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=295439</a><br>; > <<a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=295439" rel="noreferrer" target="_blank">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=295439</a>><br>; > <br> > Thanks,<br> > <br> > Mark Millard <<a href="mailto:marklmi@yahoo.com" target="_blank">marklmi@yahoo.com</a> <mailto:<a href="mailto:marklmi@yahoo.com" target="_blank">marklmi@yahoo.com</a>>> escreveu<br> > (domingo, 26/04/2026 à(s) 19:08):<br> > <br> > On 4/26/26 06:42, Dag-Erling Smørg rav wrote:<br> > > The branch main has been updated by des:<br> > ><br> > > URL: <a href="https://cgit.FreeBSD.org/src/commit/" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/</a>?<br>; > id=4dd97955e68df02b26d59e4e7c9a8167947a5164 <https://<br>; > <a href="http://cgit.FreeBSD.org/src/commit/" rel="noreferrer" target="_blank">cgit.FreeBSD.org/src/commit/</a>?<br> > id=4dd97955e68df02b26d59e4e7c9a8167947a5164><br> > ><br> > > commit 4dd97955e68df02b26d59e4e7c9a8167947a5164<br> > > Author: Dag-Erling Smørgrav <des@FreeBSD.org><br> > > AuthorDate: 2026-04-26 13:41:47 +0000<br> > > Commit: Dag-Erling Smørgrav <des@FreeBSD.org><br> > > CommitDate: 2026-04-26 13:41:47 +0000<br> > ><br> > > libpkgconf: Fix paths<br> > > <br> > > ${LOCALBASE:U} evaluates to exactly the same thing as<br> > ${LOCALBASE}.<br> > > Presumably what was meant was ${LOCALBASE:U/usr/local}.<br> > > <br> > > Fixes: b8352da33f34 ("pkgconf: import into the base<br> > system")<br> > > Reviewed by: khorben<br> > > Differential Revision: <a href="https://reviews.freebsd.org/D56642" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D56642</a><br>; > <<a href="https://reviews.freebsd.org/D56642" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D56642</a>><br>; > > ---<br> > > lib/libpkgconf/Makefile | 4 ++--<br> > > tools/build/depend-cleanup.sh | 4 ++++<br> > > 2 files changed, 6 insertions(+), 2 deletions(-)<br> > ><br> > > diff --git a/lib/libpkgconf/Makefile b/lib/libpkgconf/Makefile<br> > > index fee7f275d9ff..3cfb2172a00e 100644<br> > > --- a/lib/libpkgconf/Makefile<br> > > +++ b/lib/libpkgconf/Makefile<br> > > @@ -14,8 +14,8 @@ INCS= bsdstubs.h iter.h<br> > libpkgconf-api.h libpkgconf.h stdinc.h<br> > > <br> > > WARNS?= 3<br> > > <br> > > -CFLAGS+= -DPERSONALITY_PATH=\"/usr/share/pkgconfig/<br> > personality.d:/etc/pkgconfig/personality.d:${LOCALBASE:U}/etc/<br> > pkgconfig/personality.d\"<br> > > -CFLAGS+= -DPKG_DEFAULT_PATH=\"${LOCALBASE:U}/libdata/<br> > pkgconfig:/usr/libdata/pkgconfig:${LOCALBASE:U}/share/pkgconfig\"<br> > > +CFLAGS+= -DPERSONALITY_PATH=\"/usr/share/pkgconfig/<br> > personality.d:/etc/pkgconfig/personality.d:${LOCALBASE:U/usr/local}/<br> > etc/pkgconfig/personality.d\"<br> > > +CFLAGS+= -DPKG_DEFAULT_PATH=\"${LOCALBASE:U/usr/local}/<br> > libdata/pkgconfig:/usr/libdata/pkgconfig:${LOCALBASE:U/usr/local}/<br> > share/pkgconfig\"<br> > > CFLAGS+= -DSYSTEM_INCLUDEDIR=\"/usr/include\"<br> > > CFLAGS+= -DSYSTEM_LIBDIR=\"/usr/lib\"<br> > > CFLAGS+= -I${SRCTOP}/lib/libpkgconf -I${PKGCONFDIR}<br> > > diff --git a/tools/build/depend-cleanup.sh b/tools/build/depend-<br> > cleanup.sh<br> > > index e9c02d015368..c186c39a3448 100755<br> > > --- a/tools/build/depend-cleanup.sh<br> > > +++ b/tools/build/depend-cleanup.sh<br> > > @@ -317,6 +317,10 @@ check_epoch_and_opts<br> > > # "$OBJTOP"/tests/sys/kqueue/libkqueue/*<br> > > #fi<br> > > <br> > > +# 20250426 # libpkgconfig contains incorrect paths<br> > <br> > 2025 above is a typo?<br> > <br> > > +clean_obj lib/libpkgconf personality c pkgconfig:/share<br> > > +clean_obj lib/libpkgconf pkg c pkgconfig:/share<br> > > +<br> > > # 20251219 # libkrb5profile is now internal<br> > > for libcompat in "" $ALL_libcompats; do<br> > > dirprfx=${libcompat:+obj-lib${libcompat}}<br> > ><br> > ><br> > <br> > <br> > -- <br> > ===<br> > Mark Millard<br> > marklmi at <a href="http://yahoo.com" rel="noreferrer" target="_blank">yahoo.com</a> <<a href="http://yahoo.com" rel="noreferrer" target="_blank">http://yahoo.com</a>><br>; > <br> > <br> > <br> > -- <br> > Nuno Teixeira<br> > FreeBSD UNIX: <eduardo@FreeBSD.org> Web: <a href="https://FreeBSD.org" rel="noreferrer" target="_blank">https://FreeBSD.org</a><br>; > <<a href="https://FreeBSD.org" rel="noreferrer" target="_blank">https://FreeBSD.org</a>><br>; <br> <br> -- <br> ===<br> Mark Millard<br> marklmi at <a href="http://yahoo.com" rel="noreferrer" target="_blank">yahoo.com</a><br> </blockquote></div><div><br clear="all"></div><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><font color="#888888">Nuno Teixeira</font></div><div><div><font color="#888888"> FreeBSD UNIX: <eduardo@FreeBSD.org> Web: <a href="https://FreeBSD.org" rel="noreferrer" target="_blank">https://FreeBSD.org</a><br></font></div></div></div></div>;home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7ULO08320gYxmeoqnvvXc4cxDqLsD5aXz-WrDVgcKms6kA>