Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 21 Jul 2025 15:35:04 GMT
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: de2936aa3675 - main - tcp rack: fix clearing of app limited periods
Message-ID:  <202507211535.56LFZ4xI028462@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/commit/?id=de2936aa36754d1b63475f41a1d1429ae6fdfad8

commit de2936aa36754d1b63475f41a1d1429ae6fdfad8
Author:     Peter Lei <peterlei@netflix.com>
AuthorDate: 2025-07-21 14:01:43 +0000
Commit:     Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2025-07-21 14:01:43 +0000

    tcp rack: fix clearing of app limited periods
    
    Use the correct variable in the correct way. The app limited period
    is cleared when gp_seq is greater than or equal to
    cleared_app_ack_seq.
    
    Reviewed by:            rrs, tuexen, Nick Banks
    MFC after:              1 week
    Sponsored by:           Netflix, Inc.
    Differential Revision:  https://reviews.freebsd.org/D51441
---
 sys/netinet/tcp_stacks/rack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c
index 5280f18dc983..834e1347a152 100644
--- a/sys/netinet/tcp_stacks/rack.c
+++ b/sys/netinet/tcp_stacks/rack.c
@@ -17987,7 +17987,7 @@ start_set:
 		tp->gput_ack = tp->gput_seq + rack_get_measure_window(tp, rack);
 		rack->r_ctl.rc_gp_cumack_ts = 0;
 		if ((rack->r_ctl.cleared_app_ack == 1) &&
-		    (SEQ_GEQ(rack->r_ctl.cleared_app_ack, tp->gput_seq))) {
+		    (SEQ_GEQ(tp->gput_seq, rack->r_ctl.cleared_app_ack_seq))) {
 			/*
 			 * We just cleared an application limited period
 			 * so the next seq out needs to skip the first



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202507211535.56LFZ4xI028462>