Date: Thu, 26 Feb 2004 15:30:02 +0200 From: Ruslan Ermilov <ru@freebsd.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/gnu/usr.bin/cc/cc_tools Makefile Message-ID: <20040226133002.GA64142@ip.net.ua> In-Reply-To: <20040226234907.I2546@gamplex.bde.org> References: <200402260708.i1Q78Yib084234@repoman.freebsd.org> <20040226075830.GC68578@ip.net.ua> <20040226234907.I2546@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Thu, Feb 26, 2004 at 11:59:58PM +1100, Bruce Evans wrote: > On Thu, 26 Feb 2004, Ruslan Ermilov wrote: > > > On Wed, Feb 25, 2004 at 11:08:34PM -0800, Bruce Evans wrote: > > > bde 2004/02/25 23:08:34 PST > > > > > > FreeBSD src repository > > > > > > Modified files: > > > gnu/usr.bin/cc/cc_tools Makefile > > > Log: > > > Backed out the residue of rev.1.13 (bogus addition of -static to CFLAGS). > > > Makeworld will add -static in the correct place if needed and possible. > > > Self-hosted builds can just use the system default. > > > ... > > > What I hear, Bruce removing static bits? Has somebody abused your commit > > bit? ;-) > > I objected to these static bits before they were committed (see the logs) > and never used them. Hard-coding static libraries is just as bad as > hard-coding shared libraries. > I know, I just couldn't resist the temptation. ;) > Of course, I configure for non-hard-coded static libraries. > Who would ever doubt that? ;) > NOSHARED=yes in /etc/make.conf gives this for most > build-tools (not ones in library directories, since bsd.lib.mk doesn't > conert NOSHARED=yet to LDFLAGS+=-static). > Those should be fixed to use bsd.prog.mk instead now. I think they started using bsd.lib.mk mostly to get some modern suffix transformation rules from bsd.lib.mk, and I worked on merging sys.mk rules with ones in bsd.lib.mk, so it should be safe now to switch back to bsd.prog.mk there; bsd.lib.mk should only be used to build libraries. This comes down to the following three makefiles: ./gnu/lib/csu/Makefile ./gnu/lib/libiberty/Makefile (unused) ./gnu/usr.bin/cc/cc_tools/Makefile The last one is most tricky. ;) Cheers, -- Ruslan Ermilov FreeBSD committer ru@FreeBSD.org [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAPfTaUkv4P6juNwoRApZDAJ4/L8XUEc82SP0H28ZwFMCsymP+3wCfcnee hmK7jjlg39UW9EJP/UMVkqY= =CCmq -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040226133002.GA64142>