Date: Fri, 27 Sep 2024 10:07:14 +0000 From: Gary Jennejohn <garyj@gmx.de> To: Ian FREISLICH <ianfreislich@gmail.com> Cc: FreeBSD Current <current@freebsd.org> Subject: Re: Is INET6 a required option these days? (kernel build failure) Message-ID: <20240927120714.35169c6c@ernst.home> In-Reply-To: <229d4fea-2eed-4710-99f8-f4f91ed539c0@gmail.com> References: <229d4fea-2eed-4710-99f8-f4f91ed539c0@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 26 Sep 2024 14:58:40 -0400 Ian FREISLICH <ianfreislich@gmail.com> wrote: > Lately there have been a couple of commits that fail to build because v6= being compiled in despite INET6 being undefined. I think the latest is 90= 5db4aa88775865097714c170f4503da385747c. > > /usr/src/sys/netpfil/pf/pf.c:8762:38: error: no member named 'icmp6' in = 'union pf_headers'; did you mean 'icmp'? > =A08762 |=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 if (!pf_pull_h= dr(m, *off, &pd->hdr.icmp6, icmp_hlen, > > Ian > This happens now and then because most committers have INET6 enabled and they forget that INET6 is an option and not mandatory. I don't have INET6 enabled and have reported a number of problems in the source as a result of that. In general it's pretty simple to fix these problems by merely adding #ifdef INET6 ... #endif to the code. =2D- Gary Jennejohn
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20240927120714.35169c6c>